vgcreate fails if physical_volumes is a hash

[andylytical]

Describe the Bug

If the PV and VG don't exist yet and physical_volumes is a hash, throws this error:

Error: Execution of '/usr/sbin/vgcreate vg_backups {"/dev/sdc"=>{"unless_vg"=>"vg_backups"}}' returned 5: No device found for {"/dev/sdc"=>{"unless_vg"=>"vg_backups"}}.

Expected Behavior

Expect PV and VG creation to succeed.

Steps to Reproduce

Steps to reproduce the behavior:

1. Hiera data:

lvm::volume_groups:
  vg_backups:
    createonly: true
    physical_volumes:
      /dev/sdc:
        unless_vg: "vg_backups"
    logical_volumes:
      backups:
        fs_type: "xfs"
        mountpath: "/backups"

2. Puppet module:

include ::lvm

5. Run puppet

Environment

• Version 2.0.3
• Platform Red Hat Enterprise Linux 9.2 (Plow)
• Puppet version 7.26.0

Additional Context

Add any other context about the problem here.

[andylytical]

I have a fix for this, but applying it to the current main exposes #316.

I tested my fix by branching from c437d99 (before #316 was introduced).

I now have two branches that I could submit a PR from:

1. https://github.com/andylytical/puppetlabs-lvm/tree/fix_vgcreate (branches from current main but exposes Catalog compilation fails with: no parameter named 'yes_flag' #316)
2. https://github.com/andylytical/puppetlabs-lvm/tree/alt_fix_vgcreate (fully working fix but doesn't branch from current main)

Which branch should I use to submit a PR?