Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poolmetadatasize parameter appears to have invalid type set #327

Open
eringet opened this issue Feb 5, 2024 · 0 comments
Open

poolmetadatasize parameter appears to have invalid type set #327

eringet opened this issue Feb 5, 2024 · 0 comments
Labels

Comments

@eringet
Copy link

eringet commented Feb 5, 2024

Describe the Bug

I believe the poolmetadatasize parameter should be allowed to be a string such as '10M'
If it must be an integer and not a string, the rspec test should be updated.
Our own rspec tests fail if we set the poolmetadatasize, with
'parameter 'poolmetadatasize' expects a value of type Undef or Integer, got String'

Expected Behavior

Parameter documentation, rspec tests and parameter types are consistent.

Steps to Reproduce

poolmetadatasize parameter is set to be an integer:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/manifests/logical_volume.pp#L77

but in rspec test, a poolmetadatasize of '10M' is used:
https://github.com/puppetlabs/puppetlabs-lvm/blob/v2.1.0/spec/unit/puppet/type/logical_volume_spec.rb#L18

Environment

  • Version 2.1.0
  • Platform RHEL 8
@eringet eringet added the bug label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant