Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Started scripts - not all lines are removed #430

Open
jlocans opened this issue Dec 10, 2022 · 0 comments
Open

Getting Started scripts - not all lines are removed #430

jlocans opened this issue Dec 10, 2022 · 0 comments

Comments

@jlocans
Copy link

jlocans commented Dec 10, 2022

resetSolutions.sh - comments not removed from chapter3, AddressBook.purs
removeAnchors.sh - anchors not removed from chapter2, chapter6 no-peeking/Solutions.purs

Win 10
softmoth added a commit to softmoth/purescript-book that referenced this issue Aug 31, 2023
@softmoth
scripts: merge removeAnchors.sh and resetSolutions.sh
9af2e0e 
Keeping it all in a single `scripts/prepareExercises.sh` avoids
duplication.

Also remove the complex file finding; simply getting all source
files within the `exercises` directory is a perfect fit for what is
needed. This fixes Issue purescript-contrib#430.
softmoth added a commit to softmoth/purescript-book that referenced this issue Aug 31, 2023
@softmoth
scripts: merge removeAnchors.sh and resetSolutions.sh
fa9f8ce 
Keeping it all in a single `scripts/prepareExercises.sh` avoids
duplication.

Also remove the complex file finding; simply getting all source
files within the `exercises` directory is a perfect fit for what is
needed. This fixes Issue purescript-contrib#430.
@softmoth softmoth mentioned this issue Aug 31, 2023
Merged
milesfrain added a commit that referenced this issue Sep 6, 2023
@softmoth @milesfrain
scripts: merge removeAnchors.sh and resetSolutions.sh (#457)
427f698 
* scripts: merge removeAnchors.sh and resetSolutions.sh

Keeping it all in a single `scripts/prepareExercises.sh` avoids
duplication.

Also remove the complex file finding; simply getting all source
files within the `exercises` directory is a perfect fit for what is
needed. This fixes Issue #430.

* Simplify scripts/prepareExercises.sh

* Add prepareExercises.sh to CI

---------

Co-authored-by: Miles Frain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlocans