Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http2 #44

Closed
squidCatx opened this issue May 13, 2022 · 14 comments
Closed

Add support for http2 #44

squidCatx opened this issue May 13, 2022 · 14 comments

Comments

@squidCatx
Copy link

HTTP/2 is Stable in nodejs v10.10.0

@jamesdbrock
Copy link
Member

I want this too. For rowtype-yoga/purescript-protobuf#34

@jamesdbrock
Copy link
Member

Would http/2 be added to this repo, or would it be a separate repo?

@JordanMartinez
Copy link
Contributor

I think keeping it in this repo would make updating the ecosystem that much easier since there's one less library to fix. I'd also imagine that some things are shareable between the two, but I'm not familiar with this area.

@jamesdbrock
Copy link
Member

So would you be interested in a PR for a new module Node.HTTP2 in this repo?

@JordanMartinez
Copy link
Contributor

Sure.

@jamesdbrock
Copy link
Member

Do we want to add a spago.dhall to this repo?

@JordanMartinez
Copy link
Contributor

I'd prefer we don't add a spago.dhall here. It makes doing breaking changes easier.

@jamesdbrock
Copy link
Member

Can we add an Aff dependency to this repo for Aff modules?

The main constraint for Aff is that it only works on JavaScript backends. But Node.js also only works on JavaScript backends, so no new constraint will be introduced.

@JordanMartinez
Copy link
Contributor

I think that's fine.

@jamesdbrock
Copy link
Member

I think that's fine.

Great. Then I would also like to donate https://pursuit.purescript.org/packages/purescript-node-streams-aff/2.0.0 to purescript-node org and become a member of purescript-node org. Is that cool @JordanMartinez ?

@JordanMartinez
Copy link
Contributor

I'm fine with you becoming a member. Let me check with others first.

@jamesdbrock
Copy link
Member

I'm working on HTTP/2. I have a branch here which passes basic client/server tests for HTTP/2 and also includes an Aff API. https://github.com/jamesdbrock/purescript-node-http/tree/http2

@JordanMartinez
Copy link
Contributor

I think that's fine.

Great. Then I would also like to donate https://pursuit.purescript.org/packages/purescript-node-streams-aff/2.0.0 to purescript-node org and become a member of purescript-node org. Is that cool @JordanMartinez ?

I've sent you an invite.

@jamesdbrock jamesdbrock mentioned this issue Nov 21, 2022
4 tasks
@jamesdbrock jamesdbrock linked a pull request Nov 21, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants