fix (searchparams): getName should be get

`getName` does not exist in `URLSearchParams`'s API, and the definition
here was throwing an error because of this.

It should actually be `get`.

I checked all node versions prior to verify that it has indeed always
been `get`

Author: alphashuro

CHANGELOG.md

@@ -9,6 +9,7 @@ Breaking changes:
 New features:
 
 Bugfixes:
+- `URLSearchParams.getName` does not exist, renamed to the correct name `get`
 
 Other improvements:
 

src/Node/URL/URLSearchParams.js

@@ -6,7 +6,7 @@ export const fromStringImpl = (str) => new url.URLSearchParams(str);
 export const fromObjectImpl = (obj) => new url.URLSearchParams(obj);
 export const appendParamImpl = (name, value, params) => params.append(name, value);
 export const deleteImpl = (name, params) => params.delete(name);
-export const getNameImpl = (name, params) => params.getName(name);
+export const getImpl = (name, params) => params.get(name);
 export const getAllImpl = (name, params) => params.getAll(name);
 export const hasImpl = (name, params) => params.has(name);
 export const setImpl = (name, value, params) => params.set(name, value);

src/Node/URL/URLSearchParams.purs

@@ -5,7 +5,7 @@ module Node.URL.URLSearchParams
   , fromObject
   , appendParam
   , delete
-  , getName
+  , get
   , getAll
   , has
   , set
@@ -57,10 +57,10 @@ delete name params = runEffectFn2 deleteImpl name params
 
 foreign import deleteImpl :: EffectFn2 (String) (URLSearchParams) (Unit)
 
-getName :: String -> URLSearchParams -> Effect (Maybe String)
-getName name params = map toMaybe $ runEffectFn2 getNameImpl name params
+get :: String -> URLSearchParams -> Effect (Maybe String)
+get name params = map toMaybe $ runEffectFn2 getImpl name params
 
-foreign import getNameImpl :: EffectFn2 (String) (URLSearchParams) (Nullable String)
+foreign import getImpl :: EffectFn2 (String) (URLSearchParams) (Nullable String)
 
 getAll :: String -> URLSearchParams -> Effect (Array String)
 getAll name params = runEffectFn2 getAllImpl name params

test/Main.purs

@@ -2,17 +2,18 @@ module Test.Main where
 
 import Prelude
 
-import Effect (Effect)
-import Node.URL as URL
-import Node.URL.URLSearchParams as URL.Search
-import Foreign (unsafeReadTagged)
-import Data.Bifunctor (lmap)
-import Control.Monad.Except (runExcept)
 import Control.Monad.Error.Class (liftEither)
-import Effect.Exception (error)
+import Control.Monad.Except (runExcept)
+import Data.Bifunctor (lmap)
+import Data.Map as Map
+import Data.Maybe (Maybe(..))
 import Data.Traversable (for)
 import Data.Tuple (Tuple(..))
-import Data.Map as Map
+import Effect (Effect)
+import Effect.Exception (error)
+import Foreign (unsafeReadTagged)
+import Node.URL as URL
+import Node.URL.URLSearchParams as URL.Search
 import Test.Assert (assertEqual)
 
 main ∷ Effect Unit
@@ -54,3 +55,11 @@ main = do
           , Tuple "v" [ "a", "b" ]
           ]
       }
+
+    v <- URL.Search.get "v" search
+
+    assertEqual
+      { actual: v
+      , expected: Just "a"
+      }
+