Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move lambertw to singlediode-methods module #497

Closed
mikofski opened this issue Jun 29, 2018 · 2 comments
Closed

move lambertw to singlediode-methods module #497

mikofski opened this issue Jun 29, 2018 · 2 comments

Comments

@mikofski
Copy link
Member

Problem
some methods are in singlediode_methods while others are in pvsystem, makes sense for them to be together. also according to this comment

this is a lot of lines to read within an if/else...

Solution
move lambertw to singlediode_methods

alternatives
do nothing

Additional context
see #408 , #409 , & #410
@mikofski mikofski mentioned this issue Jun 29, 2018
Merged
6 tasks
mikofski added a commit to mikofski/pvlib-python that referenced this issue Jul 10, 2018
@mikofski
MAINT: move lambertw methods to singlediode_methods.py
f14ba04 
* closes pvlib#497
* remove lines setting ivcurve points to NotImplemented, so that they
raise an error if they are not set
* replace nested code in if: else condition for lambertw with new
private method "_lambertw" in singlediode_methods.py
* need to break out returns from private methods, there are so many
* move _golden_sect_DataFrame to pvlib.tools
* replace nested code in if: else condition for lambertw with new
private methods _lambertw_v_from_i and _lambertw_i_from_v in
singlediode_methods.py
* move _pwr_optfcn to singlediode_methods.py
@mikofski
Copy link
Member Author

@cwhanse and @wholmgren - maybe someone already asked this, but why didn't we just call this module "singlediode" why append _methods? seems like a redundant, no? Should we change it before v-0.6.0?

@wholmgren
Copy link
Member

@mikofski I don't recall a discussion of singlediode.py vs. singlediode_methods.py. I have a slight preference for singlediode.py.

@mikofski mikofski mentioned this issue Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikofski @wholmgren