Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete main-build.yml workflow #283

Open
5 tasks
huntharo opened this issue Jan 2, 2023 · 0 comments
Open
5 tasks

Delete main-build.yml workflow #283

huntharo opened this issue Jan 2, 2023 · 0 comments

Comments

@huntharo
Copy link
Collaborator

huntharo commented Jan 2, 2023

Motivations

  • main-build.yml has the same code as release.yml except it skips the last step of each publish action (the actual publish of the package)
  • This increases code to maintain
  • The BUILD-JSII label can be used to build JSII in ci.yml on PRs when needed
  • The publish step can simply be skipped on non-release builds in release.yml
  • The release build be triggered on PRs and pushes to main now, with a conditional that only proceeds if BUILD-RELEASE label is set on the PR

To-Do

  • Remove main-build.yml file
  • Add triggers to release.yml
  • Add conditional to release.yml to only build on PRs if label set
  • Add conditional to skip the publish steps when not a release trigger
  • Remove badge from README.md
@huntharo huntharo changed the title v0.3 - Delete v0.3 - Delete main-build.yml workflow Jan 2, 2023
@huntharo huntharo changed the title v0.3 - Delete main-build.yml workflow vNext - Delete main-build.yml workflow Feb 11, 2023
@huntharo huntharo added this to the v0.4 milestone Feb 11, 2023
@huntharo huntharo changed the title vNext - Delete main-build.yml workflow Delete main-build.yml workflow Feb 11, 2023
@huntharo huntharo removed this from the v0.4 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant