Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router - Routing to iframe-less versions with expiring session cookie #289

Open
3 tasks
huntharo opened this issue Jan 6, 2023 · 0 comments
Open
3 tasks

Comments

@huntharo
Copy link
Collaborator

huntharo commented Jan 6, 2023

Motivations

  • iframe-less apps use ?appver=0.0.0 to route to a specific version on page load
  • Unfortunately, on subsequent navigation (full window.location change) the appver is lost
  • We should set a session cookie that expires after, say, no 15-60 minutes, that contains the app version (under the prefix but not the app name since the app can be started without a trailing / and two apps can have overlapping names)

To-Do

  • Set cookie when query string is present
  • Clear cookie when query string is present with no value
  • Add unit tests
@huntharo huntharo changed the title v0.3 - Router - Routing to iframe-less versions with expiring session cookie v0.3 - Router - Routing to iframe-less versions with expiring session cookie Jan 7, 2023
@huntharo huntharo added this to the v0.3 milestone Feb 11, 2023
@huntharo huntharo changed the title v0.3 - Router - Routing to iframe-less versions with expiring session cookie Router - Routing to iframe-less versions with expiring session cookie Feb 11, 2023
@huntharo huntharo modified the milestones: v0.3, v0.4 Feb 11, 2023
@huntharo huntharo removed this from the v0.4 milestone Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant