Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to semantic-version instead of our custom implementation #36

Closed
Martysh12 opened this issue Feb 16, 2023 · 0 comments · Fixed by #38
Closed

Switch to semantic-version instead of our custom implementation #36

Martysh12 opened this issue Feb 16, 2023 · 0 comments · Fixed by #38
Assignees
@Martysh12
Labels
a: internal Related to internal API of the project p: 2 - normal Normal priority t: rewrite Complete or partial rewrite of something

Comments

@Martysh12
Copy link
Contributor

Why

According to CONTRIBUTING.md...

Don't reinvent the wheel

We're an open-sourced project, and like most other open-sourced projects, we depend on other projects that already implemented many things which we need in our code. It doesn't make a lot of sense to try and implement everything from the bottom, when there already are perfectly reasonable and working implementations made.

Why not use another thoroughly tested open-source implementation?

Besides, our implementation has a bug:
SemanticVersion.__str__ appends the pre-release string (self.prerelease) without adding a dash -.
So, instead of 2.0.0-1, our implementation outputs 2.0.01. That's wrong.
@ItsDrike ItsDrike added p: 2 - normal Normal priority t: rewrite Complete or partial rewrite of something a: internal Related to internal API of the project s: WIP labels Feb 16, 2023
@Martysh12 Martysh12 mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martysh12 Martysh12

Labels
a: internal Related to internal API of the project p: 2 - normal Normal priority t: rewrite Complete or partial rewrite of something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use semantic-version instead of our SemanticVersion Martysh12/mcproto
2 participants
@ItsDrike @Martysh12