-
Notifications
You must be signed in to change notification settings - Fork 0
Rename "pc" edition to "java" #26
Copy link
Copy link
Open
Labels
a: apiRelated to core public API of the projectRelated to core public API of the projectm: breakingThis introduces backwards compatibility breaking changes to the public APIThis introduces backwards compatibility breaking changes to the public APIp: 2 - normalShould be done reasonably soon, but not urgent/blockingShould be done reasonably soon, but not urgent/blockings: staleHas had no activity for a while (might get closed for inactivity/marked up for grabs soon)Has had no activity for a while (might get closed for inactivity/marked up for grabs soon)t: revisionComplete or partial rewrite of something (code cleanup, performance improvements, etc.)Complete or partial rewrite of something (code cleanup, performance improvements, etc.)
Description
Metadata
Metadata
Assignees
Labels
a: apiRelated to core public API of the projectRelated to core public API of the projectm: breakingThis introduces backwards compatibility breaking changes to the public APIThis introduces backwards compatibility breaking changes to the public APIp: 2 - normalShould be done reasonably soon, but not urgent/blockingShould be done reasonably soon, but not urgent/blockings: staleHas had no activity for a while (might get closed for inactivity/marked up for grabs soon)Has had no activity for a while (might get closed for inactivity/marked up for grabs soon)t: revisionComplete or partial rewrite of something (code cleanup, performance improvements, etc.)Complete or partial rewrite of something (code cleanup, performance improvements, etc.)
Type
Fields
No fields configured for issues without a type.
Even though in the source
minecraft-datarepo, the java edition is called "pc" edition, this is misleading and not many people know it under this name. For us, it would make more sense to refer to it as the java edition within the wrapper, for user familiarity and just use pc when loading the data internally within the lib.This should be as simple as changing the
Editionenum and renaming thePCvariant toJAVAvariant, but leaving "pc" as the value. This would be a breaking change though. We could consider deprecating, but because the lib is still in very early stages, I don't think it's necessary, especially if this is done alongside #23 , which will also be a breaking change without deprecations.