Currently, each time load_version / load_common_data is called, it will perform a fresh load from disk, this isn't ideal, as even if the version number is different, the manifest will be the same, and it's likely that this will end up getting called with the same version too, so caching here would be nice.
That said, it is possible that some people might just want a very specific part of the data and if we cache by default, we'd hold all of the data in memory, which, while not that terrible, is still a fair bit of data, so caching should probably be toggleable.
Currently, each time
load_version/load_common_datais called, it will perform a fresh load from disk, this isn't ideal, as even if the version number is different, the manifest will be the same, and it's likely that this will end up getting called with the same version too, so caching here would be nice.That said, it is possible that some people might just want a very specific part of the data and if we cache by default, we'd hold all of the data in memory, which, while not that terrible, is still a fair bit of data, so caching should probably be toggleable.