Fix test_get_events failure with sdl2-compat #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test meant to call SDL_FlushEvents() to flush all events, but instead only flushed SDL_FIRSTEVENT. This mistake was harmless until SDL3, which does have queued events at this point that must be flushed for the test expectations to be met.
Member
|
Good catch, thanks so much for the fix! Should probably add a runner with sdl2-compat to the CI suite before the next release to catch this kind of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The test meant to call
SDL_FlushEvents()to flush all events, but instead only flushedSDL_FIRSTEVENT. This mistake was harmless until SDL3, which does have queued events at this point that must be flushed for the test expectations to be met.Merge Checklist
closes #<issue-number>to automatically close an issue