Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: CI test that runs all open reviews (maybe weekly) to identify issues before we accept a package #184

Open
lwasser opened this issue Jul 4, 2024 · 0 comments
Labels
help wanted Extra attention is needed sprintable

Comments

@lwasser
Copy link
Member

lwasser commented Jul 4, 2024

Right now we have a streamlined workflow where we update contributors in the pyopensci.github.io repo using a cron job that runs

  • update-contributors
  • update-reviews
  • update-review-teams

This allows us to keep all of our current contributor data and review data current on the website.

It would also be useful to be able to run a command that gets all currently open reviews
i have code here that does this BUT because we just updated our API, that code likely needs to be modified.

It could be that the update here is

  1. modify update-reviews to take a input of type single or array that represents labels. then we could do something like

    • update-reviews -label pyos-accepted to get all reviewers with that label name pyos-accepted
    • update-reviews -type closed to get all closed reviewers
    • update-reviews -labels array-of-labels-here -type closed
  2. then we could run an additional step in CI that would get all open reviews, filter out issues that are not reviews

I am not sure what approach here is most efficient but we do need to test open reviews so we know if there are bugs in our API due to how people fill out the issue forms before we accept a package! i am very open to what this workflow looks like.

@lwasser lwasser added help wanted Extra attention is needed sprintable labels Jul 4, 2024
@lwasser lwasser moved this to Dev Ops / GitHub actions or GitHub related in pyOpenSci Help Wanted Project Board Aug 1, 2024
@lwasser lwasser changed the title Add: Ci test that runs all open reviews (maybe weekly) to identify issues before we accept a package Add: CI test that runs all open reviews (maybe weekly) to identify issues before we accept a package Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed sprintable
Projects
Status: Dev Ops / GitHub actions or GitHub related
Development

No branches or pull requests

1 participant