Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying arbitrary temperature and voltage profiles in an experiment step #4200

Open
valentinsulzer opened this issue Jun 19, 2024 Discussed in #4173 · 2 comments · May be fixed by #4855
Open

Applying arbitrary temperature and voltage profiles in an experiment step #4200

valentinsulzer opened this issue Jun 19, 2024 Discussed in #4173 · 2 comments · May be fixed by #4855

Comments

@valentinsulzer
Copy link
Member

Discussed in #4173

Originally posted by jhthompson12 June 12, 2024
Hello,

I have a few years of operational cell data, specifically cell voltage and ambient temperature, that I would like to use as the drive cycle input for a PyBaMM simulation via pybamm.step.voltage

Im breaking my simulation into daily experiment cycles where I create a pybamm.step.voltage(drive_cycle) step for each day with the time series voltage data for that day. Is there a way to also include the timeseries ambient temperature data as an input to the experiment?

I see that there is a temperature kwarg that can be provided to pybamm.step.voltage, but it looks like this can only be a fixed value?

temperature (float or string, optional) – The temperature of the step. If a float, the value is in Kelvin. If a string, the value should be a valid temperature string, e.g. “25 oC”.temperature (float or string, optional) – The temperature of the step. If a float, the value is in Kelvin. If a string, the value should be a valid temperature string, e.g. “25 oC”.temperature (float or string, optional) – The temperature of the step. If a float, the value is in Kelvin. If a string, the value should be a valid temperature string, e.g. “25 oC”.

Is it possible to define this as a timeseries like I am able to do with the voltage profile that I provide to pybamm.step.voltage as a numpy array with a time and voltage column?

@Rishab87
Copy link
Contributor

Hi, I would like to work on this issue, can it be assigned to me?

@Rishab87 Rishab87 linked a pull request Feb 17, 2025 that will close this issue
5 tasks
@Rishab87
Copy link
Contributor

I've created a PR for it, can you please review it and tell if anything's wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants