Appease warnings for MSVC

XuehaiPan · XuehaiPan · commit 2e2b7fe21475 · 2025-12-23T16:17:37.000+08:00
diff --git a/include/pybind11/detail/internals.h b/include/pybind11/detail/internals.h
@@ -604,11 +604,13 @@ Payload *atomic_get_or_create_in_state_dict(const char *key) {
         if (capsule_obj == nullptr) {
             throw error_already_set();
         }
-        if (LeakOnInterpreterShutdown && capsule_obj == new_capsule.ptr()) {
-            // Our capsule was inserted.
-            // Remove the destructor to leak the storage on interpreter shutdown.
-            if (PyCapsule_SetDestructor(capsule_obj, nullptr) < 0) {
-                throw error_already_set();
+        if PYBIND11_MAYBE_CONSTEXPR (LeakOnInterpreterShutdown) {
+            if (capsule_obj == new_capsule.ptr()) {
+                // Our capsule was inserted.
+                // Remove the destructor to leak the storage on interpreter shutdown.
+                if (PyCapsule_SetDestructor(capsule_obj, nullptr) < 0) {
+                    throw error_already_set();
+                }
             }
         }
         // - If key already existed, our `new_capsule` is not inserted, it will be destructed

Original file line number	Diff line number	Diff line change
`@@ -604,11 +604,13 @@ Payload atomic_get_or_create_in_state_dict(const char key) {`
`604`	`604`	`if (capsule_obj == nullptr) {`
`605`	`605`	`throw error_already_set();`
`606`	`606`	`}`
`607`		`- if (LeakOnInterpreterShutdown && capsule_obj == new_capsule.ptr()) {`
`608`		`- // Our capsule was inserted.`
`609`		`- // Remove the destructor to leak the storage on interpreter shutdown.`
`610`		`- if (PyCapsule_SetDestructor(capsule_obj, nullptr) < 0) {`
`611`		`- throw error_already_set();`
	`607`	`+ if PYBIND11_MAYBE_CONSTEXPR (LeakOnInterpreterShutdown) {`
	`608`	`+ if (capsule_obj == new_capsule.ptr()) {`
	`609`	`+ // Our capsule was inserted.`
	`610`	`+ // Remove the destructor to leak the storage on interpreter shutdown.`
	`611`	`+ if (PyCapsule_SetDestructor(capsule_obj, nullptr) < 0) {`
	`612`	`+ throw error_already_set();`
	`613`	`+ }`
`612`	`614`	`}`
`613`	`615`	`}`
`614`	`616`	// - If key already existed, our `new_capsule` is not inserted, it will be destructed