Use a more appropriate function name

Author: XuehaiPan

include/pybind11/detail/internals.h

@@ -421,8 +421,8 @@ inline PyThreadState *get_thread_state_unchecked() {
 /// We use this to figure out if there are or have been multiple subinterpreters active at any
 /// point. This must never go from true to false while any interpreter may be running in any
 /// thread!
-inline std::atomic<bool> &get_multiple_interpreters_seen() {
-    static std::atomic<bool> multi(false);
+inline std::atomic_bool &has_seen_non_main_interpreter() {
+    static std::atomic_bool multi(false);
     return multi;
 }
 
@@ -650,7 +650,7 @@ class internals_pp_manager {
     /// acquire the GIL. Will never return nullptr.
     std::unique_ptr<InternalsType> *get_pp() {
 #ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
-        if (get_multiple_interpreters_seen()) {
+        if (has_seen_non_main_interpreter()) {
             // Whenever the interpreter changes on the current thread we need to invalidate the
             // internals_pp so that it can be pulled from the interpreter's state dict.  That is
             // slow, so we use the current PyThreadState to check if it is necessary.
@@ -676,7 +676,7 @@ class internals_pp_manager {
     /// Drop all the references we're currently holding.
     void unref() {
 #ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
-        if (get_multiple_interpreters_seen()) {
+        if (has_seen_non_main_interpreter()) {
             last_istate_tls() = nullptr;
             internals_p_tls() = nullptr;
             return;
@@ -687,7 +687,7 @@ class internals_pp_manager {
 
     void destroy() {
 #ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
-        if (get_multiple_interpreters_seen()) {
+        if (has_seen_non_main_interpreter()) {
             auto *tstate = get_thread_state_unchecked();
             // this could be called without an active interpreter, just use what was cached
             if (!tstate || tstate->interp == last_istate_tls()) {
@@ -796,7 +796,7 @@ inline void ensure_internals() {
     pybind11::detail::get_internals_pp_manager().unref();
 #ifdef PYBIND11_HAS_SUBINTERPRETER_SUPPORT
     if (PyInterpreterState_Get() != PyInterpreterState_Main()) {
-        get_multiple_interpreters_seen() = true;
+        has_seen_non_main_interpreter() = true;
     }
 #endif
     pybind11::detail::get_internals();

include/pybind11/embed.h

@@ -202,7 +202,7 @@ inline void initialize_interpreter(bool init_signal_handlers = true,
 #endif
 
     // There is exactly one interpreter alive currently.
-    detail::get_multiple_interpreters_seen() = false;
+    detail::has_seen_non_main_interpreter() = false;
 }
 
 /** \rst
@@ -242,12 +242,12 @@ inline void initialize_interpreter(bool init_signal_handlers = true,
  \endrst */
 inline void finalize_interpreter() {
     // get rid of any thread-local interpreter cache that currently exists
-    if (detail::get_multiple_interpreters_seen()) {
+    if (detail::has_seen_non_main_interpreter()) {
         detail::get_internals_pp_manager().unref();
         detail::get_local_internals_pp_manager().unref();
 
         // We know there can be no other interpreter alive now
-        detail::get_multiple_interpreters_seen() = false;
+        detail::has_seen_non_main_interpreter() = false;
     }
 
     // Re-fetch the internals pointer-to-pointer (but not the internals itself, which might not
@@ -266,7 +266,7 @@ inline void finalize_interpreter() {
     detail::get_local_internals_pp_manager().destroy();
 
     // We know there is no interpreter alive now, so we can reset the multi-flag
-    detail::get_multiple_interpreters_seen() = false;
+    detail::has_seen_non_main_interpreter() = false;
 }
 
 /** \rst

include/pybind11/gil_safe_call_once.h

@@ -232,7 +232,7 @@ class gil_safe_call_once_and_store {
     // Indicator of fast path for single-interpreter case.
     bool is_last_storage_valid() const {
         return is_initialized_by_at_least_one_interpreter_
-               && !detail::get_multiple_interpreters_seen();
+               && !detail::has_seen_non_main_interpreter();
     }
 
     // Get the unique key for this storage instance in the interpreter's state dict.

include/pybind11/subinterpreter.h

@@ -109,7 +109,7 @@ class subinterpreter {
 
             // upon success, the new interpreter is activated in this thread
             result.istate_ = result.creation_tstate_->interp;
-            detail::get_multiple_interpreters_seen() = true; // there are now many interpreters
+            detail::has_seen_non_main_interpreter() = true; // there are now many interpreters
             detail::get_internals(); // initialize internals.tstate, amongst other things...
 
             // In 3.13+ this state should be deleted right away, and the memory will be reused for

tests/test_with_catch/test_subinterpreter.cpp

@@ -31,7 +31,7 @@ void unsafe_reset_internals_for_single_interpreter() {
     py::detail::get_local_internals_pp_manager().unref();
 
     // we know there are no other interpreters, so we can lower this. SUPER DANGEROUS
-    py::detail::get_multiple_interpreters_seen() = false;
+    py::detail::has_seen_non_main_interpreter() = false;
 
     // now we unref the static global singleton internals
     py::detail::get_internals_pp_manager().unref();