Replies: 1 comment 1 reply
-
|
@zwhfly Feel free to add. It seems like the use case could be compelling, just please be sure to add a test in your PR as well. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I found out that
pybind11::detail::iterator_policies::sequence_fast_readonlyis not default constructible.This makes the type returned by
pybind11::args::begin()not satisfying thestd::input_or_output_iteratorconcept.I added the default ctor directly in the header file: zwhfly@bfa326a, and made a test.
Given
using Iter = decltype(std::declval<pybind11::args>().begin());, this change makesstd::constructible_from<Iter>true, which makesstd::default_initializable<Iter>true, which makesstd::weakly_incrementable<Iter>true, which makesstd::input_or_output_iterator<Iter>true, which makespybind11::argssatisfystd::ranges::rangeconcept, which makes the following code work:I'm not familiar with the source code of pybind11, so I wonder would this change cause any bad effect that I don't know of?
Could it be added?
Beta Was this translation helpful? Give feedback.
All reactions