This looks right to me. I assume there are already tests which test this part of the code? Do you have any idea what additional test might have caught this earlier (e.g. we use valgrind for ndarrays, I don't know if that is possible for cuda)?

Please can you expand the PR description to explain the changes that you made.

There were no tests that covered this part of the code previously. I believe the tests I've added now ensure that the changes I made do not introduce any new bugs.

@framdani The tests look good, but I think you are missing something so that they are compiled and run in the CI. Ie. the equivalent of this file: https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py and/or this file : https://github.com/pyccel/pyccel/blob/cuda_devel/.github/actions/valgrind_run/action.yml

@EmilyBourne you're right , the tests I added were intended to be run locally for now. I'll do some research and ensure that the necessary configuration are added so that they can run in the CI.

@EmilyBourne you're right , the tests I added were intended to be run locally for now. I'll do some research and ensure that the necessary configuration are added so that they can run in the CI.

@framdani Ok. No need to reinvent the wheel, I think it should be as simple as copying this file into your folder : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py and:

• modifying it to collect .cu files instead of .c files
• Fixing the compilation command : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py#L52-L53

@EmilyBourne you're right , the tests I added were intended to be run locally for now. I'll do some research and ensure that the necessary configuration are added so that they can run in the CI.

@framdani Ok. No need to reinvent the wheel, I think it should be as simple as copying this file into your folder : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py and:

* modifying it to collect `.cu` files instead of `.c` files

* Fixing the compilation command : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py#L52-L53

that should work but we should ignore them in GitHub action for now as we can not run them.

@EmilyBourne you're right , the tests I added were intended to be run locally for now. I'll do some research and ensure that the necessary configuration are added so that they can run in the CI.

@framdani Ok. No need to reinvent the wheel, I think it should be as simple as copying this file into your folder : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py and:

* modifying it to collect `.cu` files instead of `.c` files

* Fixing the compilation command : https://github.com/pyccel/pyccel/blob/master/tests/ndarrays/conftest.py#L52-L53

that should work but we should ignore them in GitHub action for now as we can not run them.

Oh yes! I keep forgetting that we still can't run these tests. In that case I wonder if it's possible to split it into 2 tests?

1. Compile with -Wall -Werror in the CI
2. Execute (not run on CI but available for testing before merging)

Fixes pyccel-cuda#2 ?