Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.15.3 #1797

Closed
10 tasks done
drammock opened this issue May 1, 2024 · 14 comments
Closed
10 tasks done

release 0.15.3 #1797

drammock opened this issue May 1, 2024 · 14 comments

Comments

@drammock
Copy link
Collaborator

drammock commented May 1, 2024

Double check for quality-control

Prepare the codebase for a new version

  • Bump __version__ in __init__.py
  • Update our version switcher .json file with the new version
  • Make a release commit: git commit -m 'bump: 0.1.9 → 0.2.0'
  • Push the RLS commit git push upstream main
  • If a release candidate is needed, tick this box when we're now ready for a full release.

Make the release

  • Start a new GitHub release
    • Call the release the current version, e.g. v0.2.0
    • In the Choose a Tag: dropdown, type in the release name (e.g., v0.2.0) and click "Create new tag"
    • In the Target: dropdown, pin it to the release commit that you've just pushed.
    • Generate the automatic release notes, eventually manually specify the previous version (useful when several release candidate have been made)
  • Confirm that the release completed
  • Hide the previous patch version build in the RDT interface if needed.
  • Celebrate, you're done!

closes #1729

@drammock
Copy link
Collaborator Author

drammock commented May 1, 2024

Release candidate is out:

https://github.com/pydata/pydata-sphinx-theme/releases/tag/v0.15.3rc0

Weds 08 May is the target for full release. Please comment below links to any issues that folks think ought to be release blockers / are small enough bugfixes that they wouldn't need a second round RC. Maintainers: if you agree with a user about any suggested blockers, please add the impact:block-release tag to that issue.

@gabalafou
Copy link
Collaborator

I'm noticing some buggy behavior with the current/latest PyData Theme docs site. Seems potentially related.

When I go to https://pydata-sphinx-theme.readthedocs.io/en/latest/index.html, I expect to see "dev" in the version dropdown but it shows "0.15.3 (stable)" instead, and then if I click on 0.15.3, I get taken to a new page with a version warning banner at the top that says "This is documentation for an old version (0.15.2). Switch to stable version." But if I click the "Switch to stable version" button-link, I get the same version warning.

@drammock
Copy link
Collaborator Author

drammock commented May 2, 2024

I'm noticing some buggy behavior

thanks for reporting. We should definitely fix that before full release (hopefully it is a config error for our site related to the RC, not a general problem for all sites)

@trallard
Copy link
Collaborator

trallard commented May 2, 2024

I think it is indeed related to the fact that 0.15.3 is a release candidate vs. a full release.
Should keep an eye on this just in case though.

@psobolewskiPhD
Copy link

Any plans to push the RC to pypi for ease of testing?
https://pypi.org/project/pydata-sphinx-theme/#history

@drammock
Copy link
Collaborator Author

drammock commented May 3, 2024

Any plans to push the RC to pypi for ease of testing? https://pypi.org/project/pydata-sphinx-theme/#history

ha. yes, thanks for the nudge. It was supposed to happen automatically but I did the release in a hurry / didn't check, and then forgot.

@drammock
Copy link
Collaborator Author

drammock commented May 3, 2024

codecov upload failure strikes again! @trallard OK if I just nuke our codecov CI (since you and @Carreau are working on a replacement anyway)? With codecov failing, our PyPI upload job gets skipped.

@trallard
Copy link
Collaborator

trallard commented May 3, 2024

codecov upload failure strikes again! @trallard OK if I just nuke our codecov CI (since you and @Carreau are working on a replacement anyway)? With codecov failing, our PyPI upload job gets skipped.

That is absolutely fine by me @drammock

@drammock
Copy link
Collaborator Author

OK the RC has been on PyPI for ~8 days, so I plan to cut an official release today. I scanned the commits since the last RC and IMO they're all either not user-facing (test, maint, CI) or minor enough to make it OK to wrap into the release (with the possible exception of #1757)

@dbitouze
Copy link
Contributor

OK the RC has been on PyPI for ~8 days

Could you elaborate how to test this RC via PyPI?

@drammock
Copy link
Collaborator Author

OK the RC has been on PyPI for ~8 days

Could you elaborate how to test this RC via PyPI?

  • go here: https://pypi.org/project/pydata-sphinx-theme/
  • click on "release history"
  • choose 0.15.3rc1
  • on that page, under the package name/version title, is an install command with a copy button. click that, and paste result in your terminal. (or just copy-paste from right here: pip install pydata-sphinx-theme==0.15.3rc1)

@drammock
Copy link
Collaborator Author

release is blocked by #1818

@trallard
Copy link
Collaborator

@drammock I believe this is now unblocked.
Lmk if it is not and I can work on a fix.

@drammock
Copy link
Collaborator Author

all done! thanks for unblocking @trallard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants