Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think of deprecating usage of toggle buttons and dropdown in favor of native sphinx collapsible admonition. #1934

Open
Carreau opened this issue Jul 18, 2024 · 1 comment
Labels
kind: maintenance Improving maintainability and reducing technical debt needs: discussion Needs discussion before an implementation can be made

Comments

@Carreau
Copy link
Collaborator

Carreau commented Jul 18, 2024

See sphinx-doc/sphinx#12507, sphinx is implementing "native' collapsible admonition,

I know there are a few issue with accessibility for those dropdown and toggle-buttons.

I think it would be a better use of resources to focus on making acessibilty better with the current upstream PR and work to deprecated the usage of sphinx-design and sphinx-toggle-buttons directives in favor of native ones.

@trallard
Copy link
Collaborator

trallard commented Jul 22, 2024

I would be in favour of using and improving accessibility on the native collapsible components one that is in Sphinx.
That would help also reduce maintenance burden on ourend.

Though we'd need to come up with a depreciation strategy to minimise unwanted/negative impact on our users.

@trallard trallard added needs: discussion Needs discussion before an implementation can be made kind: maintenance Improving maintainability and reducing technical debt labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: maintenance Improving maintainability and reducing technical debt needs: discussion Needs discussion before an implementation can be made
Projects
None yet
Development

No branches or pull requests

2 participants