From 76630e6e3a3c5602e448a691843a046fa1be258e Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Wed, 2 Aug 2023 10:06:55 -0500
Subject: [PATCH 01/16] proof of concept

---
 docs/conf.py                                  |  1 +
 .../components/version-switcher.html          | 32 +++++++++++--------
 2 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/docs/conf.py b/docs/conf.py
index 54537a096..40c0a22df 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -175,6 +175,7 @@
     # "footer_start": ["test.html", "test.html"],
     # "secondary_sidebar_items": ["page-toc.html"],  # Remove the source buttons
     "switcher": {
+        "use_rtd": True,
         "json_url": json_url,
         "version_match": version_match,
     },
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index 974aa8c87..63f33074c 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -1,15 +1,21 @@
 {# As the version switcher will only work when JavaScript is enabled, we add it through JavaScript.
  #}
-<script>
-document.write(`
-  <div class="version-switcher__container dropdown">
-    <button id="versionswitcherbutton" type="button" role="button" class="version-switcher__button btn btn-sm navbar-btn dropdown-toggle" data-bs-toggle="dropdown" aria-haspopup="listbox" aria-controls="versionswitcherlist" aria-label="Version switcher list">
-      {{ theme_switcher.get('version_match') }}  <!-- this text may get changed later by javascript -->
-      <span class="caret"></span>
-    </button>
-    <div id="versionswitcherlist" class="version-switcher__menu dropdown-menu list-group-flush py-0" role="listbox" aria-labelledby="versionswitcherbutton">
-    <!-- dropdown will be populated by javascript on page load -->
-    </div>
-  </div>
-`);
-</script>
+{% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
+  <script>
+    document.write(`<div id="readthedocs-embed-flyout"></div>`);
+  </script>
+{% else %}
+  <script>
+    document.write(`
+      <div class="version-switcher__container dropdown">
+        <button id="versionswitcherbutton" type="button" role="button" class="version-switcher__button btn btn-sm navbar-btn dropdown-toggle" data-bs-toggle="dropdown" aria-haspopup="listbox" aria-controls="versionswitcherlist" aria-label="Version switcher list">
+          {{ theme_switcher.get('version_match') }}  <!-- this text may get changed later by javascript -->
+          <span class="caret"></span>
+        </button>
+        <div id="versionswitcherlist" class="version-switcher__menu dropdown-menu list-group-flush py-0" role="listbox" aria-labelledby="versionswitcherbutton">
+        <!-- dropdown will be populated by javascript on page load -->
+        </div>
+      </div>
+    `);
+  </script>
+{% endif %}

From da18eb8c66f24014bbe0949ac11693ccfbf9139d Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Wed, 2 Aug 2023 10:24:30 -0500
Subject: [PATCH 02/16] see if JS is interfering

---
 .../pydata_sphinx_theme/components/version-switcher.html      | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index 63f33074c..4c5d3df04 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -1,9 +1,7 @@
 {# As the version switcher will only work when JavaScript is enabled, we add it through JavaScript.
  #}
 {% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
-  <script>
-    document.write(`<div id="readthedocs-embed-flyout"></div>`);
-  </script>
+  <div id="readthedocs-embed-flyout"></div>
 {% else %}
   <script>
     document.write(`

From 49239301e18e9214d177c4c048e45d3d8c1c1cb2 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Wed, 2 Aug 2023 10:39:48 -0500
Subject: [PATCH 03/16] does it work to stick it in article container?

---
 .../theme/pydata_sphinx_theme/components/version-switcher.html  | 2 +-
 src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index 4c5d3df04..f7836bdfc 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -1,7 +1,7 @@
 {# As the version switcher will only work when JavaScript is enabled, we add it through JavaScript.
  #}
 {% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
-  <div id="readthedocs-embed-flyout"></div>
+  <div id="foo"></div>
 {% else %}
   <script>
     document.write(`
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
index b387ae3f2..fe74afb2a 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
@@ -98,6 +98,7 @@
         {% block docs_main %}
           <div class="bd-content">
             <div class="bd-article-container">
+                <div id="readthedocs-embed-flyout"></div>
               {# Article header #}
               <div class="bd-header-article">{% include "sections/header-article.html" %}</div>
               {# Article content #}

From fce672166731e5c39940a31609edd3e4f87e9541 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Wed, 2 Aug 2023 11:00:47 -0500
Subject: [PATCH 04/16] see if styling works

---
 .../components/_readthedocs-switcher.scss     | 173 ++++++++++++------
 1 file changed, 117 insertions(+), 56 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index 8e9bb83dc..9c3ea89c1 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -1,69 +1,130 @@
-.bd-sidebar-primary div#rtd-footer-container {
-  position: sticky;
-  bottom: -1rem;
-  margin: -1rem; // ignore sidebar padding
-
-  .rst-versions.rst-badge {
-    position: unset;
-    font-size: 0.9em;
-    font-family: var(--pst-font-family-base);
-    max-width: unset;
-
-    .rst-current-version {
-      display: flex;
-      align-items: center;
-      gap: 0.2rem;
-      height: 2.5rem;
-      transition: background-color 0.2s ease-out;
-      background-color: var(--pst-color-background);
-      color: var(--pst-color-success);
-      border-top: 1px solid var(--pst-color-border);
+.rst-versions {
+  position: static !important;
+  bottom: unset;
+  left: unset;
+  width: unset;
+  background: unset;
+  background-color: var(--pst-color-on-background) !important;
+  color: var(--pst-color-text-muted);
+  font-family: unset !important;
+  z-index: unset;
+  a {
+    background-color: var(--pst-color-on-background);
+    color: var(--pst-color-text-base);
+    text-decoration: unset;
+    @include link-style-hover;
+    &:hover {
+      background-color: var(--pst-color-surface);
     }
-
-    .fa.fa-book {
-      color: var(--pst-color-text-muted);
-      margin-right: auto;
-
-      &::after {
-        color: var(--pst-color-text-base);
-        content: "Read The Docs";
-        font-family: var(--pst-font-family-base);
-        font-weight: var(--pst-admonition-font-weight-heading);
+  }
+  &.rst-badge {
+    //  width: auto;
+    //  bottom: 20px;
+    //  right: 20px;
+    //  left: auto;
+    border-color: var(--pst-color-border);
+    border-radius: var(--bs-dropdown-border-radius);
+    border-width: 1px;
+    //  max-width: $nav-desktop-width;
+    //  max-height: 90%;
+    //  .icon-book {
+    //    float: none;
+    //    line-height: 30px;
+    //  }
+    //  .fa-book {
+    //    float: none;
+    //    line-height: 30px;
+    //  }
+    &.shift-up .rst-current-version {
+      text-align: unset;
+      .fa-book {
+        float: none !important;
+      }
+      .icon-book {
+        float: none;
       }
     }
-    .fa.fa-caret-down {
-      color: var(--pst-color-text-muted);
-    }
+    //  > .rst-current-version {
+    //    width: auto;
+    //    height: 30px;
+    //    line-height: 30px;
+    //    padding: 0 $base-line-height / 4;
+    display: inline-block !important;
+    //    text-align: center;
   }
-
-  .rst-versions.rst-badge.shift-up {
-    .rst-current-version {
-      border-bottom: 1px solid var(--pst-color-border);
+  //.rst-badge-small {
+  //  display: none;
+  //}
+  .rst-current-version {
+    //  padding: $base-line-height / 2;
+    background-color: var(--bs-btn-bg) !important;
+    text-align: left !important;
+    font-size: unset;
+    color: var(--pst-color-text-base) !important;
+    //  @include clearfix;
+    //  .fa {
+    //    color: $section-background-color;
+    //  }
+    .fa-book {
+      float: none;
+      display: inline-block !important;
+    }
+    .icon-book {
+      float: none;
     }
+    //  &.rst-out-of-date {
+    //    background-color: $red;
+    //    color: $white;
+    //  }
+    //  &.rst-active-old-version {
+    //    background-color: $yellow;
+    //    color: $black;
+    //  }
+  }
+  //&.shift-up {
+  //  height: auto;
+  //  max-height: 100%;
+  //  overflow-y: scroll;
+  //}
+  &.shift-up .rst-other-versions {
+    display: inline-block !important;
   }
-
   .rst-other-versions {
-    background-color: var(--pst-color-surface);
-    color: var(--pst-color-text-base);
-
-    dl {
-      dd a {
-        color: var(--pst-color-text-muted);
-      }
-    }
-
+    //  font-size: 90%;
+    //  padding: $base-line-height / 2;
+    //  display: none;
     hr {
-      background-color: var(--pst-color-border);
+      //  display: block;
+      //  height: 1px;
+      //  border: 0;
+      //  margin: 20px 0;
+      //  padding: 0;
+      border-top: solid 1px var(--pst-color-border);
     }
-
-    small a {
-      color: var(--pst-color-link);
+    dl {
+      border-top: solid 1px var(--pst-color-border);
     }
-
-    input {
-      padding-left: 0.5rem;
-      border: 1px solid var(--pst-color-border);
-      background-color: var(--pst-color-surface);
+    dd {
+      border-color: var(--pst-color-border);
+      border-radius: var(--bs-dropdown-border-radius);
+      border-width: 1px;
+      //  display: inline-block;
+      //  margin: 0;
+      a {
+        //  display: inline-block;
+        //  padding: $base-line-height / 4;
+        color: unset;
+        @include link-style-hover;
+      }
     }
   }
 }
+//@include media($tablet) {
+//  .rst-versions {
+//    width: 85%;
+//    display: none;
+//    &.shift {
+//      display: block;
+//    }
+//  }
+//}

From 9925ae51d1f5c12b51293b6612f500cf52da3866 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Thu, 3 Aug 2023 09:54:49 -0500
Subject: [PATCH 05/16] fix position

---
 .../pydata_sphinx_theme/components/version-switcher.html  | 8 +++++++-
 .../theme/pydata_sphinx_theme/layout.html                 | 1 -
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index f7836bdfc..39a413992 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -1,7 +1,13 @@
 {# As the version switcher will only work when JavaScript is enabled, we add it through JavaScript.
  #}
 {% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
-  <div id="foo"></div>
+  <script>
+    document.write(`
+      <div class="version-switcher__container dropdown">
+        <div id="readthedocs-embed-flyout"></div>
+      </div>
+    `);
+  </script>
 {% else %}
   <script>
     document.write(`
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
index fe74afb2a..b387ae3f2 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
@@ -98,7 +98,6 @@
         {% block docs_main %}
           <div class="bd-content">
             <div class="bd-article-container">
-                <div id="readthedocs-embed-flyout"></div>
               {# Article header #}
               <div class="bd-header-article">{% include "sections/header-article.html" %}</div>
               {# Article content #}

From bffa9a1dfd000f33465163f5598ea5d31332f74a Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Thu, 3 Aug 2023 10:16:01 -0500
Subject: [PATCH 06/16] more styling

---
 .../components/_readthedocs-switcher.scss     | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index 9c3ea89c1..743c0cb57 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -1,5 +1,5 @@
 .rst-versions {
-  position: static !important;
+  position: relative !important;
   bottom: unset;
   left: unset;
   width: unset;
@@ -19,12 +19,12 @@
   }
   &.rst-badge {
     //  width: auto;
-    //  bottom: 20px;
-    //  right: 20px;
-    //  left: auto;
-    border-color: var(--pst-color-border);
-    border-radius: var(--bs-dropdown-border-radius);
-    border-width: 1px;
+    appearance: button;
+    border-color: var(--pst-color-border) !important;
+    border-radius: var(--bs-dropdown-border-radius) !important;
+    border-width: 1px !important;
+    bottom: unset !important;
+    right: unset !important;
     //  max-width: $nav-desktop-width;
     //  max-height: 90%;
     //  .icon-book {
@@ -49,7 +49,6 @@
     //    height: 30px;
     //    line-height: 30px;
     //    padding: 0 $base-line-height / 4;
-    display: inline-block !important;
     //    text-align: center;
   }
   //.rst-badge-small {
@@ -86,28 +85,29 @@
   //  max-height: 100%;
   //  overflow-y: scroll;
   //}
-  &.shift-up .rst-other-versions {
-    display: inline-block !important;
-  }
+  //&.shift-up .rst-other-versions {
+  //  display: inline-block !important;
+  //}
   .rst-other-versions {
     //  font-size: 90%;
     //  padding: $base-line-height / 2;
     //  display: none;
+    color: var(--pst-color-text-muted);
     hr {
       //  display: block;
       //  height: 1px;
       //  border: 0;
       //  margin: 20px 0;
       //  padding: 0;
-      border-top: solid 1px var(--pst-color-border);
+      border-top: solid 1px var(--pst-color-border) !important;
     }
     dl {
       border-top: solid 1px var(--pst-color-border);
     }
     dd {
-      border-color: var(--pst-color-border);
-      border-radius: var(--bs-dropdown-border-radius);
-      border-width: 1px;
+      border-color: var(--pst-color-border) !important;
+      border-radius: var(--bs-dropdown-border-radius) !important;
+      border-width: 1px !important;
       //  display: inline-block;
       //  margin: 0;
       a {

From de8c3a7b5d567ee8a69f8343dd1b05e9427fe213 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Fri, 4 Aug 2023 12:22:12 -0500
Subject: [PATCH 07/16] try removing container div

---
 .../pydata_sphinx_theme/components/version-switcher.html    | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index 39a413992..63f33074c 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -2,11 +2,7 @@
  #}
 {% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
   <script>
-    document.write(`
-      <div class="version-switcher__container dropdown">
-        <div id="readthedocs-embed-flyout"></div>
-      </div>
-    `);
+    document.write(`<div id="readthedocs-embed-flyout"></div>`);
   </script>
 {% else %}
   <script>

From 3c8594620c3ee162959e0bfd26f8ae2b950611eb Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Fri, 4 Aug 2023 12:44:48 -0500
Subject: [PATCH 08/16] more styling again

---
 .../assets/scripts/pydata-sphinx-theme.js     |  2 +-
 .../components/_readthedocs-switcher.scss     | 29 ++++++++++---------
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
index bf56b0a44..4c4262ff9 100644
--- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
+++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -531,4 +531,4 @@ documentReady(addModeListener);
 documentReady(scrollToActive);
 documentReady(addTOCInteractivity);
 documentReady(setupSearchButtons);
-documentReady(initRTDObserver);
+// documentReady(initRTDObserver);
diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index 743c0cb57..859ed3b88 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -1,15 +1,8 @@
 .rst-versions {
   position: relative !important;
-  bottom: unset;
-  left: unset;
-  width: unset;
-  background: unset;
-  background-color: var(--pst-color-on-background) !important;
-  color: var(--pst-color-text-muted);
+  color: var(--pst-color-text-muted) !important;
   font-family: unset !important;
-  z-index: unset;
   a {
-    background-color: var(--pst-color-on-background);
     color: var(--pst-color-text-base);
     text-decoration: unset;
     @include link-style-hover;
@@ -20,6 +13,8 @@
   &.rst-badge {
     //  width: auto;
     appearance: button;
+    height: inherit;
+    max-height: inherit;
     border-color: var(--pst-color-border) !important;
     border-radius: var(--bs-dropdown-border-radius) !important;
     border-width: 1px !important;
@@ -37,12 +32,16 @@
     //  }
     &.shift-up .rst-current-version {
       text-align: unset;
+      display: inline;
       .fa-book {
         float: none !important;
       }
       .icon-book {
         float: none;
       }
+      > .rst-current-version {
+        height: inherit !important;
+      }
     }
     //  > .rst-current-version {
     //    width: auto;
@@ -55,10 +54,10 @@
   //  display: none;
   //}
   .rst-current-version {
-    //  padding: $base-line-height / 2;
-    background-color: var(--bs-btn-bg) !important;
+    padding: unset !important;
+    background-color: var(--pst-color-on-background) !important;
     text-align: left !important;
-    font-size: unset;
+    font-size: unset !important;
     color: var(--pst-color-text-base) !important;
     //  @include clearfix;
     //  .fa {
@@ -92,17 +91,21 @@
     //  font-size: 90%;
     //  padding: $base-line-height / 2;
     //  display: none;
-    color: var(--pst-color-text-muted);
+    position: absolute;
+    width: 300px;
+    color: var(--pst-color-text-muted) !important;
+    background-color: var(--pst-color-on-background) !important;
     hr {
       //  display: block;
       //  height: 1px;
       //  border: 0;
       //  margin: 20px 0;
       //  padding: 0;
+      border: none !important;
       border-top: solid 1px var(--pst-color-border) !important;
     }
     dl {
-      border-top: solid 1px var(--pst-color-border);
+      border-top: solid 1px var(--pst-color-border) !important;
     }
     dd {
       border-color: var(--pst-color-border) !important;

From 1a91a4c400abb038b045679ca750513f3baa16db Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Fri, 4 Aug 2023 17:10:09 -0500
Subject: [PATCH 09/16] remove cruft

---
 .../components/_readthedocs-switcher.scss     | 80 +------------------
 1 file changed, 3 insertions(+), 77 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index 859ed3b88..ce5968bd8 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -1,7 +1,6 @@
 .rst-versions {
   position: relative !important;
-  color: var(--pst-color-text-muted) !important;
-  font-family: unset !important;
+  font-family: inherit !important;
   a {
     color: var(--pst-color-text-base);
     text-decoration: unset;
@@ -11,96 +10,36 @@
     }
   }
   &.rst-badge {
-    //  width: auto;
-    appearance: button;
-    height: inherit;
-    max-height: inherit;
     border-color: var(--pst-color-border) !important;
     border-radius: var(--bs-dropdown-border-radius) !important;
+    border-style: solid !important;
     border-width: 1px !important;
     bottom: unset !important;
     right: unset !important;
-    //  max-width: $nav-desktop-width;
-    //  max-height: 90%;
-    //  .icon-book {
-    //    float: none;
-    //    line-height: 30px;
-    //  }
-    //  .fa-book {
-    //    float: none;
-    //    line-height: 30px;
-    //  }
     &.shift-up .rst-current-version {
-      text-align: unset;
-      display: inline;
       .fa-book {
         float: none !important;
       }
-      .icon-book {
-        float: none;
-      }
       > .rst-current-version {
         height: inherit !important;
       }
     }
-    //  > .rst-current-version {
-    //    width: auto;
-    //    height: 30px;
-    //    line-height: 30px;
-    //    padding: 0 $base-line-height / 4;
-    //    text-align: center;
   }
-  //.rst-badge-small {
-  //  display: none;
-  //}
   .rst-current-version {
-    padding: unset !important;
     background-color: var(--pst-color-on-background) !important;
-    text-align: left !important;
-    font-size: unset !important;
     color: var(--pst-color-text-base) !important;
-    //  @include clearfix;
-    //  .fa {
-    //    color: $section-background-color;
-    //  }
+    font-size: unset !important;
     .fa-book {
       float: none;
       display: inline-block !important;
     }
-    .icon-book {
-      float: none;
-    }
-    //  &.rst-out-of-date {
-    //    background-color: $red;
-    //    color: $white;
-    //  }
-    //  &.rst-active-old-version {
-    //    background-color: $yellow;
-    //    color: $black;
-    //  }
   }
-  //&.shift-up {
-  //  height: auto;
-  //  max-height: 100%;
-  //  overflow-y: scroll;
-  //}
-  //&.shift-up .rst-other-versions {
-  //  display: inline-block !important;
-  //}
   .rst-other-versions {
-    //  font-size: 90%;
-    //  padding: $base-line-height / 2;
-    //  display: none;
     position: absolute;
     width: 300px;
     color: var(--pst-color-text-muted) !important;
     background-color: var(--pst-color-on-background) !important;
     hr {
-      //  display: block;
-      //  height: 1px;
-      //  border: 0;
-      //  margin: 20px 0;
-      //  padding: 0;
       border: none !important;
       border-top: solid 1px var(--pst-color-border) !important;
     }
@@ -111,23 +50,10 @@
       border-color: var(--pst-color-border) !important;
       border-radius: var(--bs-dropdown-border-radius) !important;
       border-width: 1px !important;
-      //  display: inline-block;
-      //  margin: 0;
       a {
-        //  display: inline-block;
-        //  padding: $base-line-height / 4;
         color: unset;
         @include link-style-hover;
       }
     }
   }
 }
-//@include media($tablet) {
-//  .rst-versions {
-//    width: 85%;
-//    display: none;
-//    &.shift {
-//      display: block;
-//    }
-//  }
-//}

From a09c9acc8824e9e43527b93bdbbba017c7586e11 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 09:57:07 -0500
Subject: [PATCH 10/16] more styling tweaks

---
 .../styles/components/_readthedocs-switcher.scss    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index ce5968bd8..d8aeca7c6 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -2,16 +2,17 @@
   position: relative !important;
   font-family: inherit !important;
   a {
-    color: var(--pst-color-text-base);
+    color: var(--pst-color-link) !important;
     text-decoration: unset;
     @include link-style-hover;
     &:hover {
+      color: var(--pst-color-link-hover);
       background-color: var(--pst-color-surface);
     }
   }
   &.rst-badge {
     border-color: var(--pst-color-border) !important;
-    border-radius: var(--bs-dropdown-border-radius) !important;
+    border-radius: $admonition-border-radius;
     border-style: solid !important;
     border-width: 1px !important;
     bottom: unset !important;
@@ -48,11 +49,15 @@
     }
     dd {
       border-color: var(--pst-color-border) !important;
-      border-radius: var(--bs-dropdown-border-radius) !important;
+      border-radius: $admonition-border-radius !important;
+      border-style: solid !important;
       border-width: 1px !important;
       a {
-        color: unset;
+        color: var(--pst-color-text-base) !important;
         @include link-style-hover;
+        &:hover {
+          color: var(--pst-color-link-hover);
+        }
       }
     }
   }

From 8aea24b31fdcae4638fe65dd44908814c66ade72 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 10:42:22 -0500
Subject: [PATCH 11/16] try to clone flyout to smallscreen sidebar too

---
 .../assets/scripts/pydata-sphinx-theme.js      | 18 +++++++++++++++---
 .../components/version-switcher.html           |  2 +-
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
index 4c4262ff9..75e817753 100644
--- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
+++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -490,8 +490,20 @@ function initRTDObserver() {
         return;
       }
       if (mutation.addedNodes[0].data.search("Inserted RTD Footer") != -1) {
-        mutation.addedNodes.forEach((node) => {
-          document.getElementById("rtd-footer-container").append(node);
+        let flyout = mutation.addedNodes[0].cloneNode(true);
+        // copy the flyout menu to whichever of the 2 target nodes didn't already get
+        // written to by the RTD injection script.
+        document.querySelectorAll('[data-rtd-target="rtd"]').forEach((node) => {
+          if (!node.hasChildNodes()) {
+            node.appendChild(flyout);
+            flyout.onclick = toggleFlyout;
+            // replicate the onclick function RTD uses: it can't be cloned by cloneNode()
+            flyout
+              .querySelector(".rst-current-version")
+              .addEventListener("click", function (e) {
+                e.currentTarget.classList.toggleClass("shift-up");
+              });
+          }
         });
       }
     });
@@ -531,4 +543,4 @@ documentReady(addModeListener);
 documentReady(scrollToActive);
 documentReady(addTOCInteractivity);
 documentReady(setupSearchButtons);
-// documentReady(initRTDObserver);
+documentReady(initRTDObserver);
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
index 63f33074c..be5403c10 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/version-switcher.html
@@ -2,7 +2,7 @@
  #}
 {% if theme_switcher.get('use_rtd') is defined and theme_switcher.get('use_rtd') %}
   <script>
-    document.write(`<div id="readthedocs-embed-flyout"></div>`);
+    document.write(`<div id="readthedocs-embed-flyout" data-rtd-target="rtd"></div>`);
   </script>
 {% else %}
   <script>

From 2911e72ed2dfb5c63e34c1eb2df5aca7cfb8e392 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 10:46:36 -0500
Subject: [PATCH 12/16] final? style tweaks

---
 .../assets/styles/abstracts/_links.scss       | 31 ++++++++++++-------
 .../components/_readthedocs-switcher.scss     | 21 ++++++-------
 2 files changed, 28 insertions(+), 24 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss b/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
index f3fe96be1..b6e21b807 100644
--- a/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
+++ b/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
@@ -22,39 +22,46 @@ $link-underline-offset: 0.1578em !default;
 //  - 0.12em (relative to the link's text size)
 $link-hover-decoration-thickness: unquote("max(3px, .1875rem, .12em)") !default;
 
+@function if-important($important) {
+  @return #{if($important, "!important", "")};
+}
+
 //  Ensures links have an underline decoration by default - needed to meet
 // WCAG SC 1.4.1
-@mixin link-decoration {
-  text-decoration: underline;
+@mixin link-decoration($important: false) {
+  text-decoration: underline if-important($important);
 
   @if $link-underline-thickness {
-    text-decoration-thickness: $link-underline-thickness;
+    text-decoration-thickness: $link-underline-thickness
+      if-important($important);
   }
 
   @if $link-underline-offset {
-    text-underline-offset: $link-underline-offset;
+    text-underline-offset: $link-underline-offset if-important($important);
   }
 }
 
 // Ensures links have an underline decoration on hover - distinct from the
 // default behaviour
-@mixin link-decoration-hover {
+@mixin link-decoration-hover($important: true) {
   @if $link-hover-decoration-thickness {
-    text-decoration-thickness: $link-hover-decoration-thickness;
+    text-decoration-thickness: $link-hover-decoration-thickness
+      if-important($important);
     // Disable ink skipping on underlines on hover. Browsers haven't
     // standardised on this part of the spec yet, so set both properties
-    text-decoration-skip-ink: none; // Chromium, Firefox
-    text-decoration-skip: none; // Safari
+    text-decoration-skip-ink: none
+      if-important($important); // Chromium, Firefox
+    text-decoration-skip: none if-important($important); // Safari
   }
 }
 
 // Simple hover style - can be used alone or in conjunction with other mixins
 // Add the text underline and change in thickness on hover
-@mixin link-style-hover {
+@mixin link-style-hover($important: true) {
   &:hover {
-    @include link-decoration;
-    @include link-decoration-hover;
-    color: var(--pst-color-link-hover);
+    @include link-decoration($important: $important);
+    @include link-decoration-hover($important: $important);
+    color: var(--pst-color-link-hover) if-important($important);
   }
 }
 
diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index d8aeca7c6..a0675b6ab 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -3,12 +3,8 @@
   font-family: inherit !important;
   a {
     color: var(--pst-color-link) !important;
-    text-decoration: unset;
-    @include link-style-hover;
-    &:hover {
-      color: var(--pst-color-link-hover);
-      background-color: var(--pst-color-surface);
-    }
+    text-decoration: underline !important;
+    @include link-style-hover($important: true);
   }
   &.rst-badge {
     border-color: var(--pst-color-border) !important;
@@ -48,15 +44,16 @@
       border-top: solid 1px var(--pst-color-border) !important;
     }
     dd {
-      border-color: var(--pst-color-border) !important;
-      border-radius: $admonition-border-radius !important;
-      border-style: solid !important;
-      border-width: 1px !important;
       a {
+        @include link-style-hover($important: true);
         color: var(--pst-color-text-base) !important;
-        @include link-style-hover;
+        text-decoration: none !important;
         &:hover {
-          color: var(--pst-color-link-hover);
+          background-color: var(--pst-color-surface);
+          border-color: var(--pst-color-border) !important;
+          border-radius: $admonition-border-radius !important;
+          border-style: solid !important;
+          border-width: 1px !important;
         }
       }
     }

From 74d549f21ceeecb858a23202da45add87b9453f1 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 11:32:04 -0500
Subject: [PATCH 13/16] debug flyout cloning

---
 src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
index 75e817753..3e65a69cf 100644
--- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
+++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -490,11 +490,15 @@ function initRTDObserver() {
         return;
       }
       if (mutation.addedNodes[0].data.search("Inserted RTD Footer") != -1) {
+        console.log("XXX FOUND MUTATED NODE XXX");
         let flyout = mutation.addedNodes[0].cloneNode(true);
+        console.log(flyout);
         // copy the flyout menu to whichever of the 2 target nodes didn't already get
         // written to by the RTD injection script.
         document.querySelectorAll('[data-rtd-target="rtd"]').forEach((node) => {
+          console.log("XXX FOUND A TARGET NODE XXX");
           if (!node.hasChildNodes()) {
+            console.log("XXX FOUND CHILDLESS NODE XXX");
             node.appendChild(flyout);
             flyout.onclick = toggleFlyout;
             // replicate the onclick function RTD uses: it can't be cloned by cloneNode()

From a1b8a1d34b7bae395beae9360b56e9b0ea89b0a0 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 11:40:18 -0500
Subject: [PATCH 14/16] revert borders

---
 .../assets/styles/components/_readthedocs-switcher.scss    | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
index a0675b6ab..9ce841490 100644
--- a/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
+++ b/src/pydata_sphinx_theme/assets/styles/components/_readthedocs-switcher.scss
@@ -48,13 +48,6 @@
         @include link-style-hover($important: true);
         color: var(--pst-color-text-base) !important;
         text-decoration: none !important;
-        &:hover {
-          background-color: var(--pst-color-surface);
-          border-color: var(--pst-color-border) !important;
-          border-radius: $admonition-border-radius !important;
-          border-style: solid !important;
-          border-width: 1px !important;
-        }
       }
     }
   }

From 05ec5a771fb5657d74896cd865a90505fc662fdd Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 11:47:10 -0500
Subject: [PATCH 15/16] more debugging of clone

---
 src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
index 3e65a69cf..6cfbda5ab 100644
--- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
+++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -483,6 +483,7 @@ function initRTDObserver() {
   const mutatedCallback = (mutationList, observer) => {
     mutationList.forEach((mutation) => {
       // Check whether the mutation is for RTD, which will have a specific structure
+      console.log(`XXX {mutation.type} XXX`);
       if (mutation.addedNodes.length === 0) {
         return;
       }

From 1d36e92ae546407eff5c1853f12585fce372ccf4 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sat, 5 Aug 2023 12:10:07 -0500
Subject: [PATCH 16/16] proper default

---
 src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss b/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
index b6e21b807..368860f6a 100644
--- a/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
+++ b/src/pydata_sphinx_theme/assets/styles/abstracts/_links.scss
@@ -43,7 +43,7 @@ $link-hover-decoration-thickness: unquote("max(3px, .1875rem, .12em)") !default;
 
 // Ensures links have an underline decoration on hover - distinct from the
 // default behaviour
-@mixin link-decoration-hover($important: true) {
+@mixin link-decoration-hover($important: false) {
   @if $link-hover-decoration-thickness {
     text-decoration-thickness: $link-hover-decoration-thickness
       if-important($important);
@@ -57,7 +57,7 @@ $link-hover-decoration-thickness: unquote("max(3px, .1875rem, .12em)") !default;
 
 // Simple hover style - can be used alone or in conjunction with other mixins
 // Add the text underline and change in thickness on hover
-@mixin link-style-hover($important: true) {
+@mixin link-style-hover($important: false) {
   &:hover {
     @include link-decoration($important: $important);
     @include link-decoration-hover($important: $important);