feat: add test cases

Signed-off-by: Pavan Yekbote <[email protected]>

Author: pyek-bot

common/src/main/java/org/opensearch/ml/common/MLModel.java

@@ -50,6 +50,8 @@
 import org.opensearch.ml.common.model.TextEmbeddingModelConfig;
 import org.opensearch.telemetry.metrics.tags.Tags;
 
+import com.google.common.annotations.VisibleForTesting;
+
 import lombok.Builder;
 import lombok.Getter;
 import lombok.Setter;
@@ -862,7 +864,8 @@ public Tags getTags(Connector connector) {
         return getCustomModelTags();
     }
 
-    private Tags getRemoteModelTags(Connector connector) {
+    @VisibleForTesting
+    Tags getRemoteModelTags(Connector connector) {
         String serviceProvider = TAG_VALUE_UNKNOWN;
         String model = TAG_VALUE_UNKNOWN;
         String modelType = TAG_VALUE_UNKNOWN;
@@ -907,11 +910,8 @@ private Tags getRemoteModelTags(Connector connector) {
         return tags;
     }
 
-    /**
-     * Identifies the service provider from the connector URL
-     * Matches keywords in `MODEL_SERVICE_PROVIDER_KEYWORDS`
-     */
-    private String identifyServiceProvider(String url) {
+    @VisibleForTesting
+    String identifyServiceProvider(String url) {
         for (String provider : MODEL_SERVICE_PROVIDER_KEYWORDS) {
             if (url.contains(provider)) {
                 return provider;
@@ -921,10 +921,8 @@ private String identifyServiceProvider(String url) {
         return TAG_VALUE_UNKNOWN;
     }
 
-    /**
-     * Extracts model information based on the identified provider and URL/body patterns
-     */
-    private String identifyModel(String provider, String url, JSONObject requestBody, Connector connector) {
+    @VisibleForTesting
+    String identifyModel(String provider, String url, JSONObject requestBody, Connector connector) {
         try {
             // bedrock expects model in the url after `/model/`
             if (provider.equals(BEDROCK)) {
@@ -950,16 +948,13 @@ private String identifyModel(String provider, String url, JSONObject requestBody
         }
 
         // check if parameters has `model` -- recommended via blueprints
-        if (connector.getParameters().containsKey("model")) {
+        if (connector.getParameters() != null && connector.getParameters().containsKey("model")) {
             return connector.getParameters().get("model");
         }
 
         return TAG_VALUE_UNKNOWN;
     }
 
-    /**
-     * Utility to check if the target string contains any of the keywords.
-     */
     private static boolean containsAny(String target, List<String> keywords) {
         for (String key : keywords) {
             if (target.contains(key)) {
@@ -969,10 +964,8 @@ private static boolean containsAny(String target, List<String> keywords) {
         return false;
     }
 
-    /**
-     * Determines the model type based on the model name
-     */
-    private String identifyModelType(String model) {
+    @VisibleForTesting
+    String identifyModelType(String model) {
         if (model == null || TAG_VALUE_UNKNOWN.equals(model)) {
             return TAG_VALUE_UNKNOWN;
         }
@@ -998,12 +991,11 @@ private String identifyModelType(String model) {
         return TAG_VALUE_UNKNOWN;
     }
 
-    private Tags getPreTrainedModelTags() {
+    @VisibleForTesting
+    Tags getPreTrainedModelTags() {
         String modelType = TAG_VALUE_UNKNOWN;
-        if (this.modelConfig != null) {
-            if (this.modelConfig.getModelType() != null) {
-                modelType = this.modelConfig.getModelType();
-            }
+        if (this.modelConfig != null && this.modelConfig.getModelType() != null) {
+            modelType = this.modelConfig.getModelType();
         }
 
         String[] nameParts = this.name.split("/");
@@ -1022,7 +1014,8 @@ private Tags getPreTrainedModelTags() {
         return tags;
     }
 
-    private Tags getCustomModelTags() {
+    @VisibleForTesting
+    Tags getCustomModelTags() {
         String modelType = TAG_VALUE_UNKNOWN;
         if (this.modelConfig != null && this.modelConfig.getModelType() != null) {
             modelType = this.modelConfig.getModelType();

common/src/main/java/org/opensearch/ml/common/settings/MLFeatureEnabledSetting.java

@@ -45,9 +45,7 @@ public class MLFeatureEnabledSetting {
 
     private volatile Boolean isRagSearchPipelineEnabled;
 
-    // block any push
     private volatile Boolean isMetricCollectionEnabled;
-    // block static push
     private volatile Boolean isStaticMetricCollectionEnabled;
 
     private final List<SettingsChangeListener> listeners = new ArrayList<>();