Telemetry Aware Plugin: Adding counters and usage example #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyek-bot
commented
Mar 12, 2025
Comment on lines
1199
to
1332
| @Override | ||
| public String getJobType() { | ||
| return ML_COMMONS_JOBS_TYPE; | ||
| } | ||
|
|
||
| @Override | ||
| public String getJobIndex() { | ||
| return CommonValue.ML_JOBS_INDEX; | ||
| } | ||
|
|
||
| @Override | ||
| public ScheduledJobRunner getJobRunner() { | ||
| return MLJobRunner.getInstance(); | ||
| } | ||
|
|
||
| @Override | ||
| public ScheduledJobParser getJobParser() { | ||
| return (parser, id, jobDocVersion) -> MLJobParameter.parse(parser); | ||
| } |
Owner
Author
There was a problem hiding this comment.
ignore: these are part of job scheduler changes and not related to telemetry
pyek-bot
commented
Mar 12, 2025
| } else { | ||
| handleAsyncMLTaskComplete(mlTask); | ||
| mlModelManager.trackPredictDuration(modelId, startTime); | ||
| MLOperationalMetricsCounter.getInstance().incrementCounter(OperationalMetric.MODEL_PREDICT_COUNT, Tags.create().addTag("MODEL_ID", modelId)); |
pyek-bot
force-pushed
the
otel_metrics_integration
branch
from
26a2ea9 to
86b569b
Compare
pyek-bot
force-pushed
the
otel_metrics_integration
branch
2 times, most recently
from
66636c9 to
12f0ad6
Compare
pyek-bot
force-pushed
the
otel_metrics_integration
branch
from
8b16cd8 to
d2969c1
Compare
…try aware plugin Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
: comment code for build Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
…tureenabledsetting Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
* update agent draft Signed-off-by: Jiaping Zeng <[email protected]> * Moved tenant check & refactored response Signed-off-by: Jiaping Zeng <[email protected]> * added tests Signed-off-by: Jiaping Zeng <[email protected]> * added agent ID in success logging Signed-off-by: Jiaping Zeng <[email protected]> * modified update agent request input Signed-off-by: Jiaping Zeng <[email protected]> * updated unit tests Signed-off-by: Jiaping Zeng <[email protected]> * added input validation for update agent & replaced assert with exception Signed-off-by: Jiaping Zeng <[email protected]> * updated and added new tests Signed-off-by: Jiaping Zeng <[email protected]> * updated test name prefixes Signed-off-by: Jiaping Zeng <[email protected]> --------- Signed-off-by: Jiaping Zeng <[email protected]> Co-authored-by: Dhrubo Saha <[email protected]>
pyek-bot
force-pushed
the
otel_metrics_integration
branch
from
d2969c1 to
78056ff
Compare
…, control taskPollingJob, comment out predict metrics capture Signed-off-by: Pavan Yekbote <[email protected]>
…oject#3648) Signed-off-by: Andy Qin <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: zane-neo <[email protected]>
…3888) * function calling in agent draft Signed-off-by: Jiaping Zeng <[email protected]> * added function calling in runTool Signed-off-by: Jiaping Zeng <[email protected]> * UT fix for function calling Signed-off-by: Jiaping Zeng <[email protected]> * fixed openai llm interface Signed-off-by: Jiaping Zeng <[email protected]> * fixed test + reuse existing static where possible Signed-off-by: Jiaping Zeng <[email protected]> --------- Signed-off-by: Jiaping Zeng <[email protected]> Co-authored-by: Dhrubo Saha <[email protected]> Co-authored-by: Xun Zhang <[email protected]>
…opensearch-project#3761) Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of implementing using TelemetryAwarePlugin to capture metrics