Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: torch_geometric.nn.nlp.TXT2KG and examples/hotpot_qa.py for recall/precision eval #9728

Open
wants to merge 350 commits into
base: zacks-pr-in-mainfork
Choose a base branch
from

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Oct 23, 2024

Many RAG Q+A datasets do not have existing KGs to work with. KG creation is an essential step in the real world. This is a simplistic approach, in the future hope to have more refined approaches to replace this

Deliverable: example of making a standard RAG benchmark like hotpotQA into a KG and how to measure precision/recall of retrieval

Basing on a copy of #9666, will change base of PR to master once his work is merged

Now works at small scale, testing at full scale (10% of hotpot QA) soon. Goal is >=.5 precision/recall

@github-actions github-actions bot added the nn label Oct 23, 2024
@puririshi98 puririshi98 requested a review from wsad1 as a code owner October 23, 2024 21:27
@puririshi98 puririshi98 changed the title Draft: torch_geometric.nn.nlp.TXT2KG Draft: torch_geometric.nn.nlp.TXT2KG and examples/hotpot_qa.py for recall/precision eval Oct 25, 2024
@rjurney
Copy link

rjurney commented Nov 5, 2024

How difficult would it be to upgrade from Llama 2.0 to 3.1?

@puririshi98
Copy link
Contributor Author

How difficult would it be to upgrade from Llama 2.0 to 3.1?

im not sure what you mean. I dont use either for this PR. if your talking about the default model for the g_retriever.py example, it should be trivial for you to swap in any LLM or GNN, thats the whole point of the framework.

@puririshi98
Copy link
Contributor Author

@rjurney

@puririshi98 puririshi98 changed the base branch from zacks-pr-in-mainfork to master November 26, 2024 01:30
@puririshi98 puririshi98 changed the base branch from master to zacks-pr-in-mainfork November 26, 2024 19:44
@puririshi98
Copy link
Contributor Author

needs rebase onto master

@rjurney
Copy link

rjurney commented Dec 9, 2024

Support for Llama 3.3 79B out today that performs as well as Llama 3.1 405B for much less money… would be awesome!

riship and others added 3 commits December 9, 2024 12:50
Co-authored-by: riship <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants