Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a C++ implementation of the interfaces #21

Open
michaelosthege opened this issue Jan 10, 2022 · 0 comments
Open

Write a C++ implementation of the interfaces #21

michaelosthege opened this issue Jan 10, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@michaelosthege
Copy link
Member

michaelosthege commented Jan 10, 2022

The metadata classes can be auto-generated from the protobuf.
What's needed:

  • Package structure
  • Including a C++ protobuf compile step in scripts/generate.py:
    1. protoc -I=mcbackend/protobufs --cpp_out=$DST_DIR mcbackend/protobufs/meta.proto
    2. Move the generated files to the right place in the package structure
  • Interfaces or base classes for Backend, Run and Chain
  • Helper functions to convert between Ndarray ProtocolBuffer objects and C++ arrays (the Ndarray().data must be assigned bytes data in same encoding used by NumPy)
@michaelosthege michaelosthege added enhancement New feature or request help wanted Extra attention is needed labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant