Skip to content

Commit

Permalink
Minor typo in "Bayesian Additive Regression Trees: Introduction" note…
Browse files Browse the repository at this point in the history
…book #584 (#585)

* Fix typo in BART_introduction.myst.md

Change "season" to "reason"

* Fix typo in BART_introduction.ipynb

Changes "season" to "reason" in BART_introduction.ipynb

---------

Co-authored-by: jmellor <[email protected]>
  • Loading branch information
mellorjc and jmellor authored Oct 18, 2023
1 parent 613d1e3 commit e6eecdb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/case_studies/BART_introduction.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@
"id": "2b680d91",
"metadata": {},
"source": [
"This plot helps us understand the season behind the bad performance on the test set: Recall that in the variable importance ranking from the initial model we saw that `hour` was the most important predictor. On the other hand, our training data just sees `hour` values until $19$ (since is our train-test threshold). As BART learns how to partition the (training) data, it can not differentiate between `hour` values between $20$ and $22$ for example. It just cares that both values are greater that $19$. This is very important to understand when using BART! This explains why one should not use BART for time series forecasting if there is a trend component. In this case it is better to detrend the data first, model the remainder with BART and model the trend with a different model."
"This plot helps us understand the reason behind the bad performance on the test set: Recall that in the variable importance ranking from the initial model we saw that `hour` was the most important predictor. On the other hand, our training data just sees `hour` values until $19$ (since is our train-test threshold). As BART learns how to partition the (training) data, it can not differentiate between `hour` values between $20$ and $22$ for example. It just cares that both values are greater that $19$. This is very important to understand when using BART! This explains why one should not use BART for time series forecasting if there is a trend component. In this case it is better to detrend the data first, model the remainder with BART and model the trend with a different model."
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/case_studies/BART_introduction.myst.md
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ ax.set(
);
```

This plot helps us understand the season behind the bad performance on the test set: Recall that in the variable importance ranking from the initial model we saw that `hour` was the most important predictor. On the other hand, our training data just sees `hour` values until $19$ (since is our train-test threshold). As BART learns how to partition the (training) data, it can not differentiate between `hour` values between $20$ and $22$ for example. It just cares that both values are greater that $19$. This is very important to understand when using BART! This explains why one should not use BART for time series forecasting if there is a trend component. In this case it is better to detrend the data first, model the remainder with BART and model the trend with a different model.
This plot helps us understand the reason behind the bad performance on the test set: Recall that in the variable importance ranking from the initial model we saw that `hour` was the most important predictor. On the other hand, our training data just sees `hour` values until $19$ (since is our train-test threshold). As BART learns how to partition the (training) data, it can not differentiate between `hour` values between $20$ and $22$ for example. It just cares that both values are greater that $19$. This is very important to understand when using BART! This explains why one should not use BART for time series forecasting if there is a trend component. In this case it is better to detrend the data first, model the remainder with BART and model the trend with a different model.

+++

Expand Down

0 comments on commit e6eecdb

Please sign in to comment.