Fix dispatch of Elemwised ScalarLoop in Numba backend #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
+ Coverage 82.10% 82.12% +0.01%
==========================================
Files 185 185
Lines 48130 48127 -3
Branches 8669 8668 -1
==========================================
+ Hits 39519 39524 +5
+ Misses 6444 6438 -6
+ Partials 2167 2165 -2
|
ricardoV94
commented
Dec 26, 2024
| @@ -348,13 +347,8 @@ def axis_apply_fn(x): | |||
|
|
|||
| @numba_funcify.register(Elemwise) | |||
| def numba_funcify_Elemwise(op, node, **kwargs): | |||
| # Creating a new scalar node is more involved and unnecessary | |||
There was a problem hiding this comment.
This was not true (at least not anymore)
jessegrabowski
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1130
📚 Documentation preview 📚: https://pytensor--1137.org.readthedocs.build/en/1137/