Renamed output_type_depends_on_input_value to data_dependent_output_shapes #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Feb 14, 2025
pytensor/graph/op.py
Outdated
| @@ -195,7 +195,7 @@ class Op(MetaObject): | |||
| itypes: Sequence["Type"] | None = None | |||
| otypes: Sequence["Type"] | None = None | |||
|
|
|||
| _output_type_depends_on_input_value = False | |||
| _data_dependent_output_shapes = False | |||
There was a problem hiding this comment.
Let's do singular: data_dependent_output_shape, and remove the prefix. We can follow up with an issue to document this in creating an Op, after #1086 is merged
There was a problem hiding this comment.
I have made the changes in my new commit; could you please review them?
…s to data_dependent_output_shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced all instances of
output_type_depends_on_input_valuewithdata_dependent_output_shapesfor discoverability / standardization. Follows the Aarray API standard for this: https://data-apis.org/array-api/draft/design_topics/data_dependent_output_shapes.htmlRelated Issue
_output_type_depends_on_input_value#1188Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1209.org.readthedocs.build/en/1209/