Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize tensor.basic.py and tensor.math.py. #912

Open
ricardoV94 opened this issue Jul 10, 2024 · 2 comments
Open

Reorganize tensor.basic.py and tensor.math.py. #912

ricardoV94 opened this issue Jul 10, 2024 · 2 comments
Labels
help wanted Extra attention is needed refactor

Comments

@ricardoV94
Copy link
Member

Description

These two are doing way too much. We should probably split more along the lines of how we listed #821 if not more fine-grained.

  • Elemwise (which DimShuffle is not!)
  • Reduce: CAReduce + Argmax
  • Alloc (or tensor_creation or something): Ops that create tensors (Alloc, AllocEmpty, Diagonal, Arange, ...)

basic and math are just too big and vague. Also the rewrites should be restructured a bit to reflect the changes, although it's sometimes tricky when you are rewriting Elemwise + Reduce or Elemwise + Alloc, Probably we can put it in the non-elemwise, since that's more specific

@ricardoV94 ricardoV94 added help wanted Extra attention is needed refactor labels Jul 10, 2024
@ricardoV94
Copy link
Member Author

Also extra_ops is a mess and includes many things that make more sense elsewhere

@poojatalele
Copy link

I would like to work on this, kindly assign. @ricardoV94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactor
Projects
None yet
Development

No branches or pull requests

2 participants