Use "generic" meta types consistently #87
Labels
bug
Something isn't working
enhancement
New feature or request
important
Features and issues that need to be addressed ASAP
meta graph
This issue involves the meta graph objects
In some instances, we automatically create logic variables as stand-ins for unspecified meta object components (e.g. #35,
TFlowMetaOp.outputs
); following #84, we should always produce properly "typed" generic objects and we should also restrict meta object inputs to the expected "types" (whenever possible).For example,
TFlowMetaOp.outputs
would ideally return something strictly unifiable with a tuple ofTFlowMetaTensor
objects. As well, we shouldn't allow a strictly logic variable argument forTFlowMetaOp.op_def
, since it's possible to create aTFlowMetaOpDef
object with strictly logic variable arguments—making it just as generic, but properly "typed" (i.e. will only unify with aTFlowMetaOpDef
, but will unify with anyTFlowMetaOpDef
).This change will probably need to come alongside an easy way to generate these generic meta types (e.g. a "generic"
TFlowMetaOp
requires a "generic"TFlowMetaOpDef
).Such a consistency would also simplify the code base quite a bit, since there are numerous places where
isvar
is used to check whether or not a property is available.The text was updated successfully, but these errors were encountered: