Remove unnecessary abort() call

Co-authored-by:  kelvin <[email protected]>

Author: 2 people

pymodbus/transport/transport.py

@@ -412,8 +412,6 @@ def transport_close(self, intern: bool = False, reconnect: bool = False) -> None
         if not intern:
             self.is_closing = True
         if self.transport:
-            if hasattr(self.transport, "abort"):
-                self.transport.abort()
             self.transport.close()
             self.transport = None
         self.recv_buffer = b""
@@ -614,7 +612,7 @@ def write(self, data: bytes) -> None:
     # Dummy methods #
     # ------------- #
     def abort(self) -> None:
-        """Abort connection."""
+        """Old alias for closing the connection."""
         self.close()
 
     def can_write_eof(self) -> bool:

pymodbus/transport/transport_serial.py

@@ -117,7 +117,7 @@ def is_closing(self):
         return False
 
     def abort(self) -> None:
-        """Close the transport immediately."""
+        """Old alias for closing the connection."""
         self.close()
 
     # ------------------------------------------------

test/sub_transport/test_basic.py

@@ -188,13 +188,11 @@ async def test_broadcast_local_echo(self, client):
 
     async def test_transport_close(self, server, dummy_protocol):
         """Test transport_close()."""
-        dummy_protocol.abort = mock.MagicMock()
         dummy_protocol.close = mock.MagicMock()
         server.connection_made(dummy_protocol())
         server.recv_buffer = b"abc"
         server.reconnect_task = mock.MagicMock()
         server.transport_close()
-        dummy_protocol.abort.assert_called_once()
         dummy_protocol.close.assert_called_once()
         assert not server.recv_buffer
         await server.transport_listen()