Ignore all remaining implicit optional (#1888)

Author: alexrudd2

pymodbus/transport/transport.py

@@ -156,10 +156,10 @@ def __init__(
         self.is_server = is_server
         self.is_closing = False
 
-        self.transport: asyncio.BaseTransport = None
-        self.loop: asyncio.AbstractEventLoop = None
+        self.transport: asyncio.BaseTransport = None  # type: ignore[assignment]
+        self.loop: asyncio.AbstractEventLoop = None  # type: ignore[assignment]
         self.recv_buffer: bytes = b""
-        self.call_create: Callable[[], Coroutine[Any, Any, Any]] = lambda: None
+        self.call_create: Callable[[], Coroutine[Any, Any, Any]] = lambda: None  # type: ignore[assignment, return-value]
         if self.is_server:
             self.active_connections: dict[str, ModbusProtocol] = {}
         else:
@@ -413,7 +413,7 @@ def transport_close(self, intern: bool = False, reconnect: bool = False) -> None
             self.is_closing = True
         if self.transport:
             self.transport.close()
-            self.transport = None
+            self.transport = None  # type: ignore[assignment]
         self.recv_buffer = b""
         if self.is_server:
             for _key, value in self.active_connections.items():
@@ -515,7 +515,7 @@ def __init__(self, protocol: ModbusProtocol, listen: int | None = None) -> None:
         asyncio.DatagramTransport.__init__(self)
         asyncio.Transport.__init__(self)
         self.protocol: ModbusProtocol = protocol
-        self.other_modem: NullModem = None
+        self.other_modem: NullModem = None  # type: ignore[assignment]
         self.listen = listen
         self.manipulator: Callable[[bytes], list[bytes]] | None = None
         self._is_closing = False
@@ -589,9 +589,9 @@ def close(self) -> None:
             with suppress(KeyError):
                 del self.connections[self]
         if self.other_modem:
-            self.other_modem.other_modem = None
+            self.other_modem.other_modem = None  # type: ignore[assignment]
             self.other_modem.close()
-            self.other_modem = None
+            self.other_modem = None  # type: ignore[assignment]
         if self.protocol:
             self.protocol.connection_lost(None)
 

pymodbus/transport/transport_serial.py

@@ -51,7 +51,7 @@ def close(self, exc: Exception | None = None) -> None:
         else:
             self.async_loop.remove_reader(self.sync_serial.fileno())
         self.sync_serial.close()
-        self.sync_serial = None
+        self.sync_serial = None  # type: ignore[assignment]
         if exc:
             with contextlib.suppress(Exception):
                 self._protocol.connection_lost(exc)

pyproject.toml

@@ -189,7 +189,7 @@ overgeneral-exceptions = "builtins.Exception"
 bad-functions = "map,input"
 
 [tool.mypy]
-strict_optional = false
+strict_optional = true
 show_error_codes = true
 local_partial_types = true
 strict_equality = true