Skip to content

Commit 3f076ba

Browse files
authored
Move PyPy 3.10 to pypy-eol (#2521)
* Move PyPy 3.10 to pypy-eol * Refactor PyPy selection
1 parent dac57cc commit 3f076ba

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

cibuildwheel/selector.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,11 @@ def __call__(self, build_id: str) -> bool:
8989
return False
9090
if EnableGroup.CPythonPrerelease not in self.enable and fnmatch(build_id, "cp315*"):
9191
return False
92-
if EnableGroup.PyPy not in self.enable and fnmatch(build_id, "pp31*"):
92+
is_pypy_eol = fnmatch(build_id, "pp3?-*") or fnmatch(build_id, "pp310-*")
93+
is_pypy = fnmatch(build_id, "pp*") and not is_pypy_eol
94+
if EnableGroup.PyPy not in self.enable and is_pypy:
9395
return False
94-
if EnableGroup.PyPyEoL not in self.enable and fnmatch(build_id, "pp3?-*"):
96+
if EnableGroup.PyPyEoL not in self.enable and is_pypy_eol:
9597
return False
9698
if EnableGroup.GraalPy not in self.enable and fnmatch(build_id, "gp*"):
9799
return False

test/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,10 +287,10 @@ def _expected_wheels(
287287
python_abi_tags += [
288288
"pp38-pypy38_pp73",
289289
"pp39-pypy39_pp73",
290+
"pp310-pypy310_pp73",
290291
]
291292
if EnableGroup.PyPy in enable_groups:
292293
python_abi_tags += [
293-
"pp310-pypy310_pp73",
294294
"pp311-pypy311_pp73",
295295
]
296296

unit_test/build_selector_test.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ def test_build():
1616
assert build_selector("cp312-manylinux_x86_64")
1717
assert build_selector("cp313-manylinux_x86_64")
1818
assert build_selector("cp314-manylinux_x86_64")
19-
assert build_selector("pp310-manylinux_x86_64")
2019
assert build_selector("pp311-manylinux_x86_64")
2120
assert build_selector("cp36-manylinux_i686")
2221
assert build_selector("cp37-manylinux_i686")
@@ -62,8 +61,8 @@ def test_build_filter_pypy():
6261
skip_config="",
6362
enable=frozenset([EnableGroup.PyPy]),
6463
)
65-
assert build_selector("pp310-manylinux_x86_64")
6664
assert build_selector("pp311-manylinux_x86_64")
65+
assert not build_selector("pp310-manylinux_x86_64")
6766
assert not build_selector("pp38-manylinux_x86_64")
6867
assert not build_selector("pp39-manylinux_x86_64")
6968

@@ -74,8 +73,8 @@ def test_build_filter_pypy_eol():
7473
skip_config="",
7574
enable=frozenset([EnableGroup.PyPyEoL]),
7675
)
77-
assert not build_selector("pp310-manylinux_x86_64")
7876
assert not build_selector("pp311-manylinux_x86_64")
77+
assert build_selector("pp310-manylinux_x86_64")
7978
assert build_selector("pp38-manylinux_x86_64")
8079
assert build_selector("pp39-manylinux_x86_64")
8180

0 commit comments

Comments
 (0)