Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPy? #1099

Closed
henryiii opened this issue May 17, 2021 · 6 comments · Fixed by #1103
Closed

Add PyPy? #1099

henryiii opened this issue May 17, 2021 · 6 comments · Fixed by #1103

Comments

@henryiii
Copy link
Contributor

henryiii commented May 17, 2021

Could the PyPy interpreters (probably starting with the latest one, PyPy3.7 7.3.4 or likely 7.3.5) be added to the manylinux image? This might make it easier to provide different versions (pypy/manylinux is stuck on manylinux 2010 pypy/manylinux#7) and would avoid image issues mentioned in pypy/manylinux#15.

see @mattip in #1055 (comment)

@mayeut
Copy link
Member

mayeut commented May 17, 2021

xref pypy/manylinux#7

@mattip
Copy link
Contributor

mattip commented May 18, 2021

For x86_64, i386, and arm64 the official releases would work great as they are built inside a manylinux2010 docker. For ppc64, ppc64le, and s390x the situation is a little more complex, are Fedora 20, Fedora 21, and Rehat 7.2 respectively close enough to manylinux2014 to be useful?

@henryiii
Copy link
Contributor Author

henryiii commented May 18, 2021

I'd base it on pypy/manylinux - I think it could be added mostly with just the two scripts there, but yes, maybe those images would have to (at least at first) not include PyPy.

@mayeut
Copy link
Member

mayeut commented May 18, 2021

For ppc64, ppc64le, and s390x the situation is a little more complex, are Fedora 20, Fedora 21, and Rehat 7.2 respectively close enough to manylinux2014 to be useful?

Only s390x would work on manylinux2014 (I expect CentOS 7 to have full ABI compatibility with RHEL 7.2) but not on manylinux_2_24.
Are there any plans to use the same build process as x86_64/i686/aarch64 for s390x/ppc64le (ppc64le has no PyPy3.7 at all) ?

What would be the expectations regarding the versions of PyPy, there are 5 versions for now in the PyPy images.
Given that PyPy 3.6 seems to be abandoned and that manylinux images dropped support for python 2.7, I'd assume that only including PyPy3.7 7.3.4 would be okay for this transition (or wait for 7.3.5, start with 7.3.5rc2) ?

@henryiii
Copy link
Contributor Author

My recommendation would be to just focus on the latest version (PyPy3.7 7.3.4 or PyPy3.7 7.3.5 very soon). If "old" versions of PyPy are needed, then there's the "pypy/manylinux" image. But just sticking with the latest "supported" pypy3's (Usually 1-2 Python versions) seems reasonable? "pypy/manylinux" could provide more comprehensive, classic PyPy support if needed. Or users could use old manylinux images in the future if they need old PyPy versions, just like they have to do now with Python 2.7/3.5.

@mattip
Copy link
Contributor

mattip commented May 19, 2021

agreed: there is no need to provide older versions of PyPy. We encourage users to upgrade to the latest versions since support for c-extension modules gets better with each release.

mayeut added a commit to mayeut/manylinux that referenced this issue May 22, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 22, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 23, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 23, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 23, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 23, 2021
mayeut added a commit to mayeut/manylinux that referenced this issue May 23, 2021
mayeut added a commit that referenced this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants