"These apps are now globally available" is confusing now that --global is a thing

[dechamps]

$ pipx --version
1.6.0
$ pipx install cowsay
  installed package cowsay 6.1, installed using Python 3.11.9
  These apps are now globally available
    - cowsay
done! ✨ 🌟 ✨

The phrasing "These apps are now globally available" seems to imply that I asked for a system-wide install using --global, but I didn't (and it didn't). This is confusing.

Alternatives include:

• Just writing "These apps are now available"
• Writing "These apps are now available user-wide" or "These apps are now available system-wide" depending on whether --global was passed

[NerusSkyhigh]

Hi everyone,
I saw the tag "good first issue" and tried to help solve it.
I edited the file commands/common.py on line 352 with the first alternative suggested but while running the test I encountered some failures:

conda create --name pipx-test python pip
conda activate pipx-test
python -m pip install -e .
python -m pip install --user nox
nox -s tests-3.12

================================ short test summary info ================================
FAILED tests/test_environment.py::test_cli - AssertionError: assert False
FAILED tests/test_install.py::test_install_fetch_missing_python_invalid[3.1] - AssertionError: assert 0
= 2 failed, 344 passed, 8 skipped, 124 deselected, 1 xpassed, 7 warnings in 879.96s (0:14:39) =
nox > Command pytest --cov=pipx --cov-report= tests failed with exit code 1
nox > Session tests-3.12 failed.

As I don't think the line in itself is wrong (I mean, I only changed a string), I may need some help understanding the tests work so that I can contribute correctly. Any suggestion is welcome.

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

[huxuan]

I saw the tag "good first issue" and tried to help solve it.

Thanks and welcome, @NerusSkyhigh!

I may need some help understanding the tests work so that I can contribute correctly. Any suggestion is welcome.

I would suggest to create a pull request in case there is some local environment releate error. If not, it is still more convenient to deal with the problem directly based on the pull request together.

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

IMO, it is fine. The globally term is kind of ambiguous. Let us wait for other buddies' response.

[NerusSkyhigh]

Hi, thanks for your time @huxuan .
I sent the pull request with the first change. Feel free to let me know if you need anything else.

For the second change, I'll wait for others' responses and change that if needed.

[Gitznik]

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

We might as well make it consistent while we're at it IMO.