Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building data download with an overpass query v2 #52

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

Emre-Yorat89
Copy link
Contributor

@Emre-Yorat89 Emre-Yorat89 commented Sep 20, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The improvements are:

  • Overpass query is modified to download multiple microgrids building data
  • An option is presented to the user for downloading building data with earth osm package or overpass query in the config file.
  • Snakefile is modified to resolve the issue when download_osm_buildings_overpass flag set to true and download_osm_buildings set to false.

Checklist

  • I consent to the release of this PR's code under the GPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to the main environment at PyPSA-Earth repository
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Emre-Yorat89 :D
Very close to finalize and merge :D

@@ -18,6 +18,7 @@ enable:
retrieve_cost_data: true
download_osm_data: true
download_osm_buildings: false
download_osm_buildings_overpass: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting proposal, to have a new option here.

What about instead adding an option like: download_osm_method: overpass # or earth_osm? :)
This allows to keep a single retrieve option and it may be clearer. What do you think?
For the rest, this is great :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions, I have tried to implement them as you described. Hopefully, it is fine now :)

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it much! :D
The CI is not running, I'm waiting for it to work; just to inform you.
Great to have you back :D

@Emre-Yorat89
Copy link
Contributor Author

Emre-Yorat89 commented Oct 25, 2024

Hi Davide,
I have faced a few issues in the scripts that proces json microgrid files by geopandas. The problem is geopandas does not read json data format basically it wants building data as in .geojson format. So I am working on a script that translates json file to .geojson file for now. If you are agree too I am going to implement the solution to download_osm_data script after it is ready. What do you think?
Many thanks for your helps. :)

@Emre-Yorat89 Emre-Yorat89 marked this pull request as draft November 4, 2024 11:19
@Emre-Yorat89 Emre-Yorat89 requested a review from davide-f November 5, 2024 11:23
@davide-f davide-f marked this pull request as ready for review November 19, 2024 14:14
@davide-f davide-f merged commit 1ebed85 into pypsa-meets-earth:main Dec 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants