-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building data download with an overpass query v2 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @Emre-Yorat89 :D
Very close to finalize and merge :D
config.distribution.yaml
Outdated
@@ -18,6 +18,7 @@ enable: | |||
retrieve_cost_data: true | |||
download_osm_data: true | |||
download_osm_buildings: false | |||
download_osm_buildings_overpass: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting proposal, to have a new option here.
What about instead adding an option like: download_osm_method: overpass # or earth_osm? :)
This allows to keep a single retrieve option and it may be clearer. What do you think?
For the rest, this is great :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestions, I have tried to implement them as you described. Hopefully, it is fine now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it much! :D
The CI is not running, I'm waiting for it to work; just to inform you.
Great to have you back :D
Hi Davide, |
Closes # (if applicable).
Changes proposed in this Pull Request
The improvements are:
Checklist
config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.