Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test routine #1052

Open
2 tasks done
FabianHofmann opened this issue Jul 1, 2024 · 1 comment
Open
2 tasks done

Refactor test routine #1052

FabianHofmann opened this issue Jul 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@FabianHofmann
Copy link
Collaborator

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-earth environment. Update via conda env update -f envs/environment.yaml.

Problem Statement

Currently the test routine uses nested snakemake calls where snakemake is called via a bash command in the Snakefile. This architecture omits error streams and snakemake runs that fail are not reported as such, see https://github.com/pypsa-meets-earth/pypsa-earth/actions/runs/9667460555/job/26669336528#step:9:1739.

Suggestion

I would propose to execute snakemake in the GH workflow and optionally keep the commands in a common file for easy local execution, like https://github.com/PyPSA/pypsa-eur/blob/master/test.sh

I would as well propose to collect all workflow CI's in one yaml that uses a matrix entry for setting the operation systems.

@davide-f
Copy link
Member

davide-f commented Jul 3, 2024

Wow!

That is a quite big bug! Thanks for reporting.
Indeed this shouldn't be difficult as that was our previous configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants