You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we introduced a logger framework in the integration tests we should go ahead and replace all log messages which are printed with "echo" with "log INFO".
Additional details
No response
The text was updated successfully, but these errors were encountered:
@karolh2000 Do we want to do this globally? I found load '../lib/logger/load' so I know we would add that to any script that's missing it (right?), and then just echo becomes log INFO? Sometimes there's a mix. For example,
From bats/tests/common-setup.bash:
log INFO "Integration tests are running using this version of Pyrsia: ${latest_commit}"
log INFO "For more details, refer to https://github.com/pyrsia/pyrsia/commit/$(echo "${latest_commit}"| awk '{print $1}') (This link works properly only when you test pyrsia/pyrsia repository.)"echo"Building the Pyrsia CLI sources (Pyrsia CLI source dir: $PYRSIA_TEMP_DIR), it might take a while...">&3
cargo build -q --profile=release --package=pyrsia_cli --manifest-path=$PYRSIA_TEMP_DIR/Cargo.toml
@karolh2000 Do we want to do this globally? I found load '../lib/logger/load' so I know we would add that to any script that's missing it (right?), and then just echo becomes log INFO? Sometimes there's a mix. For example,
From bats/tests/common-setup.bash:
log INFO "Integration tests are running using this version of Pyrsia: ${latest_commit}"
log INFO "For more details, refer to https://github.com/pyrsia/pyrsia/commit/$(echo "${latest_commit}"| awk '{print $1}') (This link works properly only when you test pyrsia/pyrsia repository.)"echo"Building the Pyrsia CLI sources (Pyrsia CLI source dir: $PYRSIA_TEMP_DIR), it might take a while...">&3
cargo build -q --profile=release --package=pyrsia_cli --manifest-path=$PYRSIA_TEMP_DIR/Cargo.toml
@efrischlog.info/debug was introduced later on to reduce the amount of info printed if not in the "debug" mode. Unfortunately, we have a legacy code that uses echo. Basically this issue serves as a reminder to replace "echo" with "log.info/debug" where possible.
Suggestion details
Since we introduced a logger framework in the integration tests we should go ahead and replace all log messages which are printed with "echo" with "log INFO".
Additional details
No response
The text was updated successfully, but these errors were encountered: