Accounting for incoming API changes to libpysal and adding testing against libpysal's master branch
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh yes, also I link this with pysal/spreg#9 and http://ljwolf.org/post/testingmatrix/ |
sjsrey
reviewed
Jul 31, 2018
Member
sjsrey
left a comment
sjsrey
left a comment
There was a problem hiding this comment.
There are some duplicates of liblibpysal which should be libpysal
esda/geary.py
Outdated
| >>> from esda.geary import Geary | ||
| >>> w = lps.open(lps.get_path("book.gal")).read() | ||
| >>> f = lps.open(lps.get_path("book.txt")) | ||
| >>> w = libpysal.io.open(liblibpysal.examples.get_path("book.gal")).read() |
esda/geary.py
Outdated
| >>> w = lps.open(lps.get_path("book.gal")).read() | ||
| >>> f = lps.open(lps.get_path("book.txt")) | ||
| >>> w = libpysal.io.open(liblibpysal.examples.get_path("book.gal")).read() | ||
| >>> f = libpysal.io.open(liblibpysal.examples.get_path("book.txt")) |
Member
|
Looks like it is ready to merge as the travis tests against libpysal master branch are passing? When I run the tests on my local machine, there are some errors in the doctests on Headbanging_Triples. I noticed that it is a depreciated function whose unittest is skipped and PR #11 is working on a substitution. Are we going to keep the depreciated function for the next release or integrate the work in PR #11 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this adds some documentation fixes for
libpysal's API change, in attempts to clean up the api for migrating topysal 2.0, as we outline onmigrating.pysal.org.Note that, the way these test are configured now, the "allow_failures" will pass, and the mandatory tests will fail. This is because I have not yet created a
pypirelease oflibpysal. But, using this optional github-focused test battery, we can see when there are changes in libpysal that may affect our library. That said, no more changes to existing libpysal APIs will occur, and submodule maintainers should probably import directly from the python file in which their function exists.