Repository navigation
fix support for obj parameter of Class.from_parent #7063
Description
in c99c7d0#r38397315 @blueyed noted a ignored optional parameter
as far as i remember this is a refactoring artifact i accidentally left,
i should ensure it can be used
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
blueyed commentedon Apr 9, 2020
Classnever took anobj.I've noticed this when optimizing things to use passed-in objects.
RonnyPfannschmidt commentedon Apr 9, 2020
@blueyed as i said its a refactoring artifact i accidentally left
it will be revisited as pretty much everything should try to use passed in objects
blueyed commentedon Apr 9, 2020
Yeah. I've came across this when noticing that typically both
FunctionDefinitionandFunctionare being created - both creating the obj etc.As for your "please coordinate" comment on #7052 you might want to provide some reference to why
FunctionDefinitionis needed / what's the plan with it.RonnyPfannschmidt commentedon Apr 10, 2020
Functiondefinition is the node which represents a function without parameterization, its collect method should run generate_tests
blueyed commentedon Apr 10, 2020
Will it be named
objthen still?Functionusescallobjfor it currently/already.RonnyPfannschmidt commentedon Apr 10, 2020
yes, , obj is the intenral/semantical name used in practically all nodes, the function object using callobj will deprecate/disappear with the introduction of functiondefinition in the collection tree
Class.from_parent: remove unused obj
LuanaPBueno commentedon Oct 22, 2026
Opened pytest-dev/pytest#15247 for this.
Use the obj passed to Class.from_parent