feat: support no default accumulator v2

we have no default accumulator v2 in Pythtest conformance

Author: ali-behjati

.github/workflows/docker.yaml

@@ -72,6 +72,15 @@ jobs:
           asset_name: pyth_oracle_pythnet.so
           tag: ${{ github.ref }}
 
+      - name : Publish Pythnet No Default Accumulator v2 binary
+        if : env.IS_ORACLE_RELEASE == 'true'
+        uses: svenstaro/upload-release-action@133984371c30d34e38222a64855679a414cb7575
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ./pyth_oracle_pythnet_no_accumulator.so
+          asset_name: pyth_oracle_pythnet_no_default_accumulator_v2.so
+          tag: ${{ github.ref }}
+
   pinning:
     runs-on: ubuntu-latest
     steps:

program/rust/Cargo.toml

@@ -45,6 +45,7 @@ time = "=0.3.7"
 check = [] # Skips make build in build.rs, use with cargo-clippy and cargo-check
 debug = []
 library = ["solana-sdk"]
+no-default-accumulator-v2 = []
 
 [lib]
 crate-type = ["cdylib", "lib"]

program/rust/src/processor/add_price.rs

@@ -84,9 +84,12 @@ pub fn add_price(
     price_data.next_price_account = product_data.first_price_account;
     price_data.min_pub_ = PRICE_ACCOUNT_DEFAULT_MIN_PUB;
     price_data.feed_index = reserve_new_price_feed_index(permissions_account)?;
-    price_data
-        .flags
-        .insert(PriceAccountFlags::ACCUMULATOR_V2 | PriceAccountFlags::MESSAGE_BUFFER_CLEARED);
+
+    if !cfg!(feature = "no-default-accumulator_v2") {
+        price_data
+            .flags
+            .insert(PriceAccountFlags::ACCUMULATOR_V2 | PriceAccountFlags::MESSAGE_BUFFER_CLEARED);
+    }
 
     product_data.first_price_account = *price_account.key;
 

program/rust/src/tests/test_full_publisher_set.rs

@@ -79,8 +79,13 @@ async fn test_full_publisher_set() -> Result<(), Box<dyn std::error::Error>> {
             .await
             .unwrap();
 
-        assert_eq!(price_data.agg_.price_, 0);
-        assert_eq!(price_data.agg_.conf_, 0);
+        if cfg!(feature = "no-default-accumulator-v2") {
+            assert_eq!(price_data.agg_.price_, 110);
+            assert_eq!(price_data.agg_.conf_, 20);
+        } else {
+            assert_eq!(price_data.agg_.price_, 0);
+            assert_eq!(price_data.agg_.conf_, 0);
+        }
     }
 
     Ok(())

program/rust/src/tests/test_publish.rs

@@ -102,8 +102,14 @@ async fn test_publish() {
         assert_eq!(price_data.comp_[0].latest_.conf_, 0);
         assert_eq!(price_data.comp_[0].latest_.status_, PC_STATUS_UNKNOWN);
 
-        assert_eq!(price_data.comp_[0].agg_.price_, 0);
-        assert_eq!(price_data.comp_[0].agg_.conf_, 0);
-        assert_eq!(price_data.comp_[0].agg_.status_, PC_STATUS_UNKNOWN);
+        if cfg!(feature = "no-default-accumulator-v2") {
+            assert_eq!(price_data.agg_.price_, 150);
+            assert_eq!(price_data.agg_.conf_, 7);
+            assert_eq!(price_data.agg_.status_, PC_STATUS_TRADING);
+        } else {
+            assert_eq!(price_data.agg_.price_, 0);
+            assert_eq!(price_data.agg_.conf_, 0);
+            assert_eq!(price_data.agg_.status_, PC_STATUS_UNKNOWN);
+        }
     }
 }

program/rust/src/tests/test_publish_batch.rs

@@ -111,7 +111,7 @@ async fn test_publish_batch() {
             .get_account_data_as::<PriceAccount>(*price)
             .await
             .unwrap();
-        let _quote = quotes.get(key).unwrap();
+        let quote = quotes.get(key).unwrap();
         let new_quote = new_quotes.get(key).unwrap();
 
         assert_eq!(price_data.comp_[0].latest_.price_, new_quote.price);
@@ -125,8 +125,18 @@ async fn test_publish_batch() {
             )
             .unwrap()
         );
-        assert_eq!(price_data.comp_[0].agg_.price_, 0);
-        assert_eq!(price_data.comp_[0].agg_.conf_, 0);
-        assert_eq!(price_data.comp_[0].agg_.status_, PC_STATUS_UNKNOWN);
+        if cfg!(feature = "no-default-accumulator-v2") {
+            assert_eq!(price_data.comp_[0].agg_.price_, quote.price);
+            assert_eq!(price_data.comp_[0].agg_.conf_, quote.confidence);
+            assert_eq!(
+                price_data.comp_[0].agg_.status_,
+                get_status_for_conf_price_ratio(quote.price, quote.confidence, quote.status)
+                    .unwrap()
+            );
+        } else {
+            assert_eq!(price_data.comp_[0].agg_.price_, 0);
+            assert_eq!(price_data.comp_[0].agg_.conf_, 0);
+            assert_eq!(price_data.comp_[0].agg_.status_, PC_STATUS_UNKNOWN);
+        }
     }
 }

scripts/build-bpf.sh

@@ -19,12 +19,19 @@ set -x
 # Build both parts of the program (both C and rust) via Cargo
 cd "${PYTH_DIR}"
 
-# Re-run tests affected by features
 cargo-test-bpf
-
 cargo-build-bpf -- --locked -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort
 sha256sum ./target/**/*.so
 echo "Checking size of pyth_oracle.so for pythnet"
 ./scripts/check-size.sh 88429
 mkdir -p target/pyth/pythnet/
 mv target/deploy/pyth_oracle.so target/pyth/pythnet/pyth_oracle_pythnet.so
+
+# Re-run tests affected by features
+cargo-test-bpf -- --features no-default-accumulator-v2
+cargo-build-bpf -- --locked -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort --features no-default-accumulator-v2
+sha256sum ./target/**/*.so
+echo "Checking size of pyth_oracle.so for pythnet with no accumulator"
+./scripts/check-size.sh 88429
+mkdir -p target/pyth/pythnet/
+mv target/deploy/pyth_oracle.so target/pyth/pythnet/pyth_oracle_pythnet_no_accumulator_v2.so