add: `test_check_schema_builtin & use ABC

Author: Borda

src/check_jsonschema/schema_loader/main.py

@@ -5,6 +5,7 @@
 import typing as t
 import urllib.error
 import urllib.parse
+from abc import ABC
 
 import jsonschema
 
@@ -59,7 +60,7 @@ def _extend_with_pattern_implementation(
     )
 
 
-class SchemaLoaderBase:
+class SchemaLoaderBase(ABC):
     def get_validator(
         self,
         path: pathlib.Path | str,
@@ -68,7 +69,7 @@ def get_validator(
         regex_impl: RegexImplementation,
         fill_defaults: bool,
     ) -> jsonschema.protocols.Validator:
-        raise NotImplementedError
+        pass
 
 
 class SchemaLoader(SchemaLoaderBase):

tests/unit/cli/test_schemas.py

@@ -0,0 +1,20 @@
+import jsonschema
+import pytest
+
+from check_jsonschema.builtin_schemas import get_builtin_schema
+from check_jsonschema.cli.main_command import BUILTIN_SCHEMA_NAMES
+from check_jsonschema.regex_variants import RegexImplementation, RegexVariantName
+from check_jsonschema.schema_loader.main import _check_schema
+
+
+@pytest.mark.parametrize("name", BUILTIN_SCHEMA_NAMES)
+def test_check_schema_builtin(name):
+    """
+    Test that the buildin schema is valid
+    """
+    regex_impl = RegexImplementation(RegexVariantName.default)
+    schema = get_builtin_schema(name)
+
+    # get the correct validator class and check the schema under its metaschema
+    validator_cls = jsonschema.validators.validator_for(schema)
+    _check_schema(validator_cls, schema, regex_impl=regex_impl)