Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge overlapping dependencies subschemas #57

Closed
Zac-HD opened this issue Jul 12, 2020 · 0 comments
Closed

Merge overlapping dependencies subschemas #57

Zac-HD opened this issue Jul 12, 2020 · 0 comments

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Jul 12, 2020

In hypothesis_jsonschema._canonicalise.merged(), we should calculate the intersection of dependencies keywords from two schemas.

This is complicated somewhat by the fact that dependencies can be either the bare names, or also schemas. I think if they are of different kinds we can 'promote' the names to a mapping of name to {} (which accepts any value), but it needs some more investigation.

JSONschema draft 2019-09 changed this, but we don't support it yet anyway so that can be left for later.

@Zac-HD Zac-HD closed this as completed in cf548f2 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant