Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a validator that corresponds to the input schema draft version #67

Merged

Conversation

Stranger6667
Copy link
Contributor

Fixes #66

Hi!

Initially, I thought adding metaschema_validator without a default, but it would be inconvenient in tests, so I have a couple of questions :)

  • Would the metaschema_validator name work, or should I rename it to something shorter?
  • Default values. Is it OK tas it is implemented? Otherwise, I could add some shortcut for tests, so it will be easier to spot if validators are passed everywhere

Cheers!

@Stranger6667 Stranger6667 force-pushed the dd/validators-metaschema branch 2 times, most recently from 220481a to 0d251ba Compare September 9, 2020 15:58
@Stranger6667 Stranger6667 force-pushed the dd/validators-metaschema branch from 0d251ba to 98d0051 Compare September 9, 2020 15:59
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stranger6667!

@Zac-HD Zac-HD merged commit 6a3ef60 into python-jsonschema:master Sep 10, 2020
@Stranger6667 Stranger6667 deleted the dd/validators-metaschema branch September 10, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The input schema draft version should be used in all validators
2 participants