Skip to content

Commit e4f2a4a

Browse files
authored
Merge pull request #8717 from radarhere/none
Use Py_RETURN_NONE macro when possible
2 parents a9d05a1 + f598c03 commit e4f2a4a

12 files changed

+83
-242
lines changed

src/_imaging.c

+31-62
Original file line numberDiff line numberDiff line change
@@ -473,8 +473,7 @@ getpixel(Imaging im, ImagingAccess access, int x, int y) {
473473
}
474474

475475
/* unknown type */
476-
Py_INCREF(Py_None);
477-
return Py_None;
476+
Py_RETURN_NONE;
478477
}
479478

480479
static char *
@@ -965,8 +964,7 @@ _convert2(ImagingObject *self, PyObject *args) {
965964
return NULL;
966965
}
967966

968-
Py_INCREF(Py_None);
969-
return Py_None;
967+
Py_RETURN_NONE;
970968
}
971969

972970
static PyObject *
@@ -1214,8 +1212,7 @@ _getpixel(ImagingObject *self, PyObject *args) {
12141212
}
12151213

12161214
if (self->access == NULL) {
1217-
Py_INCREF(Py_None);
1218-
return Py_None;
1215+
Py_RETURN_NONE;
12191216
}
12201217

12211218
return getpixel(self->image, self->access, x, y);
@@ -1417,8 +1414,7 @@ _paste(ImagingObject *self, PyObject *args) {
14171414
return NULL;
14181415
}
14191416

1420-
Py_INCREF(Py_None);
1421-
return Py_None;
1417+
Py_RETURN_NONE;
14221418
}
14231419

14241420
static PyObject *
@@ -1691,8 +1687,7 @@ _putdata(ImagingObject *self, PyObject *args) {
16911687

16921688
Py_XDECREF(seq);
16931689

1694-
Py_INCREF(Py_None);
1695-
return Py_None;
1690+
Py_RETURN_NONE;
16961691
}
16971692

16981693
static PyObject *
@@ -1752,8 +1747,7 @@ _putpalette(ImagingObject *self, PyObject *args) {
17521747
self->image->palette->size = palettesize * 8 / bits;
17531748
unpack(self->image->palette->palette, palette, self->image->palette->size);
17541749

1755-
Py_INCREF(Py_None);
1756-
return Py_None;
1750+
Py_RETURN_NONE;
17571751
}
17581752

17591753
static PyObject *
@@ -1777,8 +1771,7 @@ _putpalettealpha(ImagingObject *self, PyObject *args) {
17771771
strcpy(self->image->palette->mode, "RGBA");
17781772
self->image->palette->palette[index * 4 + 3] = (UINT8)alpha;
17791773

1780-
Py_INCREF(Py_None);
1781-
return Py_None;
1774+
Py_RETURN_NONE;
17821775
}
17831776

17841777
static PyObject *
@@ -1805,8 +1798,7 @@ _putpalettealphas(ImagingObject *self, PyObject *args) {
18051798
self->image->palette->palette[i * 4 + 3] = (UINT8)values[i];
18061799
}
18071800

1808-
Py_INCREF(Py_None);
1809-
return Py_None;
1801+
Py_RETURN_NONE;
18101802
}
18111803

18121804
static PyObject *
@@ -1842,8 +1834,7 @@ _putpixel(ImagingObject *self, PyObject *args) {
18421834
self->access->put_pixel(im, x, y, ink);
18431835
}
18441836

1845-
Py_INCREF(Py_None);
1846-
return Py_None;
1837+
Py_RETURN_NONE;
18471838
}
18481839

18491840
static PyObject *
@@ -2010,8 +2001,7 @@ im_setmode(ImagingObject *self, PyObject *args) {
20102001
}
20112002
self->access = ImagingAccessNew(im);
20122003

2013-
Py_INCREF(Py_None);
2014-
return Py_None;
2004+
Py_RETURN_NONE;
20152005
}
20162006

20172007
static PyObject *
@@ -2074,8 +2064,7 @@ _transform(ImagingObject *self, PyObject *args) {
20742064
return NULL;
20752065
}
20762066

2077-
Py_INCREF(Py_None);
2078-
return Py_None;
2067+
Py_RETURN_NONE;
20792068
}
20802069

20812070
static PyObject *
@@ -2202,8 +2191,7 @@ _getbbox(ImagingObject *self, PyObject *args) {
22022191
}
22032192

22042193
if (!ImagingGetBBox(self->image, bbox, alpha_only)) {
2205-
Py_INCREF(Py_None);
2206-
return Py_None;
2194+
Py_RETURN_NONE;
22072195
}
22082196

22092197
return Py_BuildValue("iiii", bbox[0], bbox[1], bbox[2], bbox[3]);
@@ -2283,8 +2271,7 @@ _getextrema(ImagingObject *self) {
22832271
}
22842272
}
22852273

2286-
Py_INCREF(Py_None);
2287-
return Py_None;
2274+
Py_RETURN_NONE;
22882275
}
22892276

22902277
static PyObject *
@@ -2347,8 +2334,7 @@ _fillband(ImagingObject *self, PyObject *args) {
23472334
return NULL;
23482335
}
23492336

2350-
Py_INCREF(Py_None);
2351-
return Py_None;
2337+
Py_RETURN_NONE;
23522338
}
23532339

23542340
static PyObject *
@@ -2363,8 +2349,7 @@ _putband(ImagingObject *self, PyObject *args) {
23632349
return NULL;
23642350
}
23652351

2366-
Py_INCREF(Py_None);
2367-
return Py_None;
2352+
Py_RETURN_NONE;
23682353
}
23692354

23702355
static PyObject *
@@ -2950,8 +2935,7 @@ _draw_arc(ImagingDrawObject *self, PyObject *args) {
29502935
return NULL;
29512936
}
29522937

2953-
Py_INCREF(Py_None);
2954-
return Py_None;
2938+
Py_RETURN_NONE;
29552939
}
29562940

29572941
static PyObject *
@@ -2988,8 +2972,7 @@ _draw_bitmap(ImagingDrawObject *self, PyObject *args) {
29882972
return NULL;
29892973
}
29902974

2991-
Py_INCREF(Py_None);
2992-
return Py_None;
2975+
Py_RETURN_NONE;
29932976
}
29942977

29952978
static PyObject *
@@ -3045,8 +3028,7 @@ _draw_chord(ImagingDrawObject *self, PyObject *args) {
30453028
return NULL;
30463029
}
30473030

3048-
Py_INCREF(Py_None);
3049-
return Py_None;
3031+
Py_RETURN_NONE;
30503032
}
30513033

30523034
static PyObject *
@@ -3100,8 +3082,7 @@ _draw_ellipse(ImagingDrawObject *self, PyObject *args) {
31003082
return NULL;
31013083
}
31023084

3103-
Py_INCREF(Py_None);
3104-
return Py_None;
3085+
Py_RETURN_NONE;
31053086
}
31063087

31073088
static PyObject *
@@ -3164,8 +3145,7 @@ _draw_lines(ImagingDrawObject *self, PyObject *args) {
31643145

31653146
free(xy);
31663147

3167-
Py_INCREF(Py_None);
3168-
return Py_None;
3148+
Py_RETURN_NONE;
31693149
}
31703150

31713151
static PyObject *
@@ -3196,8 +3176,7 @@ _draw_points(ImagingDrawObject *self, PyObject *args) {
31963176

31973177
free(xy);
31983178

3199-
Py_INCREF(Py_None);
3200-
return Py_None;
3179+
Py_RETURN_NONE;
32013180
}
32023181

32033182
/* from outline.c */
@@ -3225,8 +3204,7 @@ _draw_outline(ImagingDrawObject *self, PyObject *args) {
32253204
return NULL;
32263205
}
32273206

3228-
Py_INCREF(Py_None);
3229-
return Py_None;
3207+
Py_RETURN_NONE;
32303208
}
32313209

32323210
static PyObject *
@@ -3282,8 +3260,7 @@ _draw_pieslice(ImagingDrawObject *self, PyObject *args) {
32823260
return NULL;
32833261
}
32843262

3285-
Py_INCREF(Py_None);
3286-
return Py_None;
3263+
Py_RETURN_NONE;
32873264
}
32883265

32893266
static PyObject *
@@ -3334,8 +3311,7 @@ _draw_polygon(ImagingDrawObject *self, PyObject *args) {
33343311

33353312
free(ixy);
33363313

3337-
Py_INCREF(Py_None);
3338-
return Py_None;
3314+
Py_RETURN_NONE;
33393315
}
33403316

33413317
static PyObject *
@@ -3389,8 +3365,7 @@ _draw_rectangle(ImagingDrawObject *self, PyObject *args) {
33893365
return NULL;
33903366
}
33913367

3392-
Py_INCREF(Py_None);
3393-
return Py_None;
3368+
Py_RETURN_NONE;
33943369
}
33953370

33963371
static struct PyMethodDef _draw_methods[] = {
@@ -3595,8 +3570,7 @@ _save_ppm(ImagingObject *self, PyObject *args) {
35953570
return NULL;
35963571
}
35973572

3598-
Py_INCREF(Py_None);
3599-
return Py_None;
3573+
Py_RETURN_NONE;
36003574
}
36013575

36023576
/* -------------------------------------------------------------------- */
@@ -3984,8 +3958,7 @@ _reset_stats(PyObject *self, PyObject *args) {
39843958
arena->stats_freed_blocks = 0;
39853959
MUTEX_UNLOCK(&ImagingDefaultArena.mutex);
39863960

3987-
Py_INCREF(Py_None);
3988-
return Py_None;
3961+
Py_RETURN_NONE;
39893962
}
39903963

39913964
static PyObject *
@@ -4045,8 +4018,7 @@ _set_alignment(PyObject *self, PyObject *args) {
40454018
ImagingDefaultArena.alignment = alignment;
40464019
MUTEX_UNLOCK(&ImagingDefaultArena.mutex);
40474020

4048-
Py_INCREF(Py_None);
4049-
return Py_None;
4021+
Py_RETURN_NONE;
40504022
}
40514023

40524024
static PyObject *
@@ -4070,8 +4042,7 @@ _set_block_size(PyObject *self, PyObject *args) {
40704042
ImagingDefaultArena.block_size = block_size;
40714043
MUTEX_UNLOCK(&ImagingDefaultArena.mutex);
40724044

4073-
Py_INCREF(Py_None);
4074-
return Py_None;
4045+
Py_RETURN_NONE;
40754046
}
40764047

40774048
static PyObject *
@@ -4099,8 +4070,7 @@ _set_blocks_max(PyObject *self, PyObject *args) {
40994070
return ImagingError_MemoryError();
41004071
}
41014072

4102-
Py_INCREF(Py_None);
4103-
return Py_None;
4073+
Py_RETURN_NONE;
41044074
}
41054075

41064076
static PyObject *
@@ -4115,8 +4085,7 @@ _clear_cache(PyObject *self, PyObject *args) {
41154085
ImagingMemoryClearCache(&ImagingDefaultArena, i);
41164086
MUTEX_UNLOCK(&ImagingDefaultArena.mutex);
41174087

4118-
Py_INCREF(Py_None);
4119-
return Py_None;
4088+
Py_RETURN_NONE;
41204089
}
41214090

41224091
/* -------------------------------------------------------------------- */

0 commit comments

Comments
 (0)