Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for getpass #130524

Open
donBarbos opened this issue Feb 24, 2025 · 3 comments
Open

Add more tests for getpass #130524

donBarbos opened this issue Feb 24, 2025 · 3 comments
Labels
tests Tests in the Lib/test dir

Comments

@donBarbos
Copy link
Contributor

donBarbos commented Feb 24, 2025

This is something I thought of when working #130496, I noticed that some tests were missing.
Test Lib/test/test_getpass.py only has three classes: GetpassGetuserTest, GetpassRawinputTest, UnixGetpassTest.

This clearly doesn't cover all cases, I think we should add at least WinGetpassTest and check that both implementations (unix_getpass and win_getpass) work the same.

Linked PRs

@ZeroIntensity ZeroIntensity added the tests Tests in the Lib/test dir label Feb 24, 2025
@tomasr8
Copy link
Member

tomasr8 commented Feb 24, 2025

Just an FYI, the devguide has some information on how to systematically measure and increase test coverage: https://devguide.python.org/testing/coverage/

@floor-licker
Copy link

Can I work on this?

@donBarbos
Copy link
Contributor Author

Can I work on this?

yeah, i think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

4 participants