🐛 Scope the nominee preview's nominator lookup to the election

Author: JacobCoffee

apps/nominations/tests/test_views.py

@@ -389,6 +389,13 @@ def test_preview_excludes_nominations_by_other_people(self):
         response = self.client.get(self._url(self.election))
         self.assertNotIn(self.unrelated_nominee, response.context["object_list"])
 
+    def test_preview_ignores_nominations_filed_under_another_election(self):
+        # A nomination whose election disagrees with its nominee's (possible via the admin).
+        self._nomination(self.other_election, self.nominator, self.unrelated_nominee)
+        self.client.force_login(self.nominator)
+        response = self.client.get(self._url(self.election))
+        self.assertNotIn(self.unrelated_nominee, response.context["object_list"])
+
     def test_preview_includes_the_user_as_a_candidate(self):
         self.client.force_login(self.nominator)
         response = self.client.get(self._url(self.other_election))

apps/nominations/views.py

@@ -78,7 +78,8 @@ def get_queryset(self, *args, **kwargs):
             # themselves when somebody nominated them.
             return (
                 Nominee.objects.filter(
-                    Q(user=self.request.user) | Q(nominations__nominator=self.request.user),
+                    Q(user=self.request.user)
+                    | Q(nominations__nominator=self.request.user, nominations__election=election),
                     election=election,
                 )
                 .exclude(user=None)