Fix #2626: Duplicate scheduled year for single day events (#2934)

* Fix #2626: Duplicate scheduled year for single day events

- Removes redundant rendering of next_time.dt_start year block inside time_tag.html for single_day events
- Adds unit tests to ensure the DOM output for single day events generates the year precisely once.

* Update apps/events/tests/test_templates.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update apps/events/tests/test_templates.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Address Copilot PR reviews: timezone-aware tests, robust assertions, Ruff compliance (Issue #2626)

* Format test_templates.py with ruff

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jeff Triplett <jeff.triplett@gmail.com>
Co-authored-by: Jacob Coffee <jacob@z7x.org>

Author: 4 people

apps/events/templates/events/includes/time_tag.html

@@ -4,10 +4,6 @@
             {{ next_time.dt_start|date:"Y" }}
         </span>
 
-        <span id="start-{{ object.id }}"{% if scheduled_end_this_year %} class="say-no-more"{% endif %}>
-            {{ next_time.dt_start|date:"Y" }}
-        </span>
-
         {% if not next_time.all_day %}
             {{ next_time.dt_start|date:"fA"|lower }} {{ next_time.dt_start|date:"e" }}
                 {% if next_time.valid_dt_end %} – {{ next_time.dt_end|date:"fA"|lower }}

apps/events/tests/test_templates.py

@@ -0,0 +1,55 @@
+import datetime
+import re
+
+from django.template.loader import render_to_string
+from django.test import TestCase
+from django.utils import timezone
+
+from apps.events.models import Calendar, Event
+
+
+class TimeTagTemplateTests(TestCase):
+    def test_single_day_event_year_rendering(self):
+        """
+        Verify that a single-day event does not render the year twice (Issue #2626).
+        """
+        future_year = timezone.now().date().year + 1
+
+        calendar = Calendar.objects.create(
+            name="Test Calendar",
+            slug="test-calendar-time-tag-single-day-event",
+        )
+        event = Event.objects.create(
+            title="Single Day Future Event",
+            description="Test event",
+            calendar=calendar,
+        )
+
+        # Use timezone-aware datetimes to match the project's USE_TZ = True setting.
+        class MockTime:
+            def __init__(self):
+                self.dt_start = datetime.datetime(future_year, 5, 25, 12, 0, tzinfo=datetime.UTC)
+                self.dt_end = datetime.datetime(future_year, 5, 25, 14, 0, tzinfo=datetime.UTC)
+                self.single_day = True
+                self.all_day = False
+                self.valid_dt_end = True
+
+        context = {
+            "next_time": MockTime(),
+            "scheduled_start_this_year": False,
+            "scheduled_end_this_year": False,
+            "object": event,
+        }
+
+        rendered = render_to_string("events/includes/time_tag.html", context)
+
+        # Count visible year occurrences inside <span> tags using a regex.
+        # This avoids brittle exact-whitespace matching and ignores the
+        # year inside the <time datetime="..."> ISO attribute.
+        year_str = str(future_year)
+        year_in_span = re.findall(r"<span[^>]*>\s*" + re.escape(year_str) + r"\s*</span>", rendered)
+        self.assertEqual(
+            len(year_in_span),
+            1,
+            f"Expected the year {year_str} to appear in exactly one <span>, but found {len(year_in_span)}: {rendered}",
+        )