Skip to content

Commit d008bf1

Browse files
committed
fix: 잘못된 useEffect dependency로 무한 요청이 보내지는 문제 수정
1 parent 26bf13a commit d008bf1

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

apps/pyconkr-admin/src/components/layouts/admin_editor.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,15 +144,16 @@ const InnerAdminEditor: React.FC<AppResourceIdType & AdminEditorPropsType> =
144144
}
145145

146146
setFormDataState(
147-
await Common.BackendAdminAPIs.retrieve<Record<string, string>>(
147+
(await Common.BackendAdminAPIs.retrieve<Record<string, string>>(
148148
backendAdminClient,
149149
app,
150150
resource,
151151
id
152-
)()
152+
)()) || {}
153153
);
154154
})();
155-
}, [app, id, resource, backendAdminClient]);
155+
// eslint-disable-next-line react-hooks/exhaustive-deps
156+
}, [app, resource, id]);
156157

157158
const onSubmitButtonClick: React.MouseEventHandler<
158159
HTMLButtonElement

packages/common/src/apis/admin_api.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,10 @@ namespace BackendAdminAPIs {
3131

3232
export const retrieve =
3333
<T>(client: BackendAPIClient, app: string, resource: string, id: string) =>
34-
() =>
35-
client.get<T>(`v1/admin-api/${app}/${resource}/${id}/`);
34+
() => {
35+
if (!id) return Promise.resolve(null);
36+
return client.get<T>(`v1/admin-api/${app}/${resource}/${id}/`);
37+
};
3638

3739
export const create =
3840
<T>(client: BackendAPIClient, app: string, resource: string) =>

0 commit comments

Comments
 (0)