-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove torchvision as dependency #3158
Conversation
Note that the latest nightly torchvision has depended on torch 2.6.0.dev, so installing torchtrt wheel will fail because it still depends on torch 2.5.0.dev. |
@@ -12,3 +12,6 @@ transformers==4.40.2 | |||
# TODO @lanlao-nvidia Renable when modelopt can be install properly to run the tests | |||
# "nvidia-modelopt[all]">=0.16.1,<0.17.0 | |||
--extra-index-url https://pypi.nvidia.com | |||
torchvision>=0.20.0.dev,<0.21.0 | |||
--extra-index-url https://download.pytorch.org/whl/nightly/cu124 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this extra-index-url
is redundant. We already have INDEX_URL
defined in install-torch-tensorrt.sh
which has templated channel and cu_version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, It is redundant.
in the install-torch-tensorrt.sh it is templated with channel and cu_version.
I still want to keep this --extra-index-url here just in case that developer run:
python -m pip install --pre -r tests/py/requirements.txt in their local environment to test
How many tests are getting altered from this changed? Are there tests where we could just use a simple network that we host and get similar impact for testing and not have to disable it? I think we really only care about torchvision models in cases where we specifically want to test that model architecture (so we should have at least 1 resnet, 1 bert, 1 vit test) or we need real weights for some reason |
we have specified the torchvison version so that make sure it is compatible with torch version in the test.
@narendasan I can see most times we just use torchvision.resnet18 to test our features, it can be replaced with other simple network. I think for test_models.py is where we should actually use these torchvision.resnet18 and movilenet_v2 models for testing. |
Be aware that all tests were failed to run even though they all showed green. https://github.com/pytorch/TensorRT/actions/runs/10887326997/job/30210220619?pr=3158#step:12:522 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: